From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KgGYB-0006VK-SG for qemu-devel@nongnu.org; Thu, 18 Sep 2008 06:15:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KgGY9-0006UZ-Ou for qemu-devel@nongnu.org; Thu, 18 Sep 2008 06:15:50 -0400 Received: from [199.232.76.173] (port=44811 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KgGY9-0006UU-CY for qemu-devel@nongnu.org; Thu, 18 Sep 2008 06:15:49 -0400 Received: from ug-out-1314.google.com ([66.249.92.171]:23925) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KgGY9-0000T4-3q for qemu-devel@nongnu.org; Thu, 18 Sep 2008 06:15:49 -0400 Received: by ug-out-1314.google.com with SMTP id j3so683445ugf.36 for ; Thu, 18 Sep 2008 03:15:47 -0700 (PDT) Date: Thu, 18 Sep 2008 13:16:30 +0300 From: "Kirill A. Shutemov" Subject: Re: [Qemu-devel] [PATCH] add futimesat syscall Message-ID: <20080918101629.GB9799@localhost.localdomain> References: <20080917194533.GB21187@kos.to> <20080918063007.GA26841@kos.to> <761ea48b0809180023t37d300ceq790fe33c5ab7602a@mail.gmail.com> <20080918090821.GA17893@kos.to> <20080918092826.GA5059@localhost.localdomain> <20080918094234.GA23737@kos.to> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EuxKj2iCbKjpUGkD" Content-Disposition: inline In-Reply-To: <20080918094234.GA23737@kos.to> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Riku Voipio Cc: qemu-devel@nongnu.org --EuxKj2iCbKjpUGkD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 18, 2008 at 12:42:34PM +0300, Riku Voipio wrote: > On Thu, Sep 18, 2008 at 12:28:31PM +0300, Kirill A. Shutemov wrote: > > On Thu, Sep 18, 2008 at 12:08:21PM +0300, Riku Voipio wrote: > > I don't think that it's great idea. If libc/kernel headers doesn't prov= ide > > the syscall we shouldn't implement them. The exception is syscalls with= out > > libc's wrapper. Like gettid(2). >=20 > Well, defining syscalls appears to be a common practice in qemu for the > *at family of syscalls (openat, linkat, ...), so it doesn't seem that > far off for futimesat(). *at syscalls ware implemented in linux 2.6.16. glibc's wrappers to this syscalls were implemented in glibc 2.4. Both of them relesed more than two and half years ago. I think we can drop this crap now. --=20 Regards, Kirill A. Shutemov + Belarus, Minsk + ALT Linux Team, http://www.altlinux.com/ --EuxKj2iCbKjpUGkD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkjSKn0ACgkQbWYnhzC5v6rKOgCfe+1vbF0wTFFeCMOHgfgZHVtt F3EAni6kYEJdXQ0cxnvjcc21FSQU0wYy =y1Kb -----END PGP SIGNATURE----- --EuxKj2iCbKjpUGkD--