From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KgajN-00029R-Ja for qemu-devel@nongnu.org; Fri, 19 Sep 2008 03:48:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KgajL-00028N-5C for qemu-devel@nongnu.org; Fri, 19 Sep 2008 03:48:44 -0400 Received: from [199.232.76.173] (port=46983 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KgajK-000287-Mq for qemu-devel@nongnu.org; Fri, 19 Sep 2008 03:48:42 -0400 Received: from mx20.gnu.org ([199.232.41.8]:28132) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KgajJ-0003VP-UY for qemu-devel@nongnu.org; Fri, 19 Sep 2008 03:48:42 -0400 Received: from ik-out-1112.google.com ([66.249.90.176]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KgajI-0005qC-8n for qemu-devel@nongnu.org; Fri, 19 Sep 2008 03:48:40 -0400 Received: by ik-out-1112.google.com with SMTP id c21so201221ika.2 for ; Fri, 19 Sep 2008 00:48:38 -0700 (PDT) Date: Fri, 19 Sep 2008 10:49:24 +0300 From: "Kirill A. Shutemov" Subject: Re: [Qemu-devel] [PATCH] qdd fadvise64_64 syscall Message-ID: <20080919074922.GA18614@localhost.localdomain> References: <20080917194528.GA21187@kos.to> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="RnlQjJ0d97Da+TV1" Content-Disposition: inline In-Reply-To: <20080917194528.GA21187@kos.to> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org --RnlQjJ0d97Da+TV1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 17, 2008 at 10:45:28PM +0300, Riku Voipio wrote: > Since it's only a hint, we can just add a happy passwtrough. Also > from scratchbox. >=20 > Signed-off-by: Riku Voipio > --=20 > "rm -rf" only sounds scary if you don't have backups > Index: trunk/linux-user/arm/syscall_nr.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- trunk.orig/linux-user/arm/syscall_nr.h 2008-09-07 02:32:28.000000000 = +0300 > +++ trunk/linux-user/arm/syscall_nr.h 2008-09-17 22:08:04.000000000 +0300 > @@ -273,6 +273,7 @@ > #define TARGET_NR_fstatfs64 267 > #define TARGET_NR_tgkill 268 > #define TARGET_NR_utimes 269 > +#define TARGET_NR_fadvise64_64 270 > #define TARGET_NR_arm_fadvise64_64 270 > #define TARGET_NR_pciconfig_iobase 271 > #define TARGET_NR_pciconfig_read 272 It's wrong. ARM doesn't provide fadvise64_64 syscall. It provides arm_fadvise64_64 with different argument order. > Index: trunk/linux-user/syscall.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- trunk.orig/linux-user/syscall.c 2008-09-17 21:43:47.000000000 +0300 > +++ trunk/linux-user/syscall.c 2008-09-17 22:08:51.000000000 +0300 > @@ -5532,6 +5532,12 @@ > } > break; > #endif > +#ifdef TARGET_NR_fadvise64_64 > + case TARGET_NR_fadvise64_64: > + /* This is a hint, so ignoring and returning success is ok. */ > + ret =3D get_errno(0); > + break; > +#endif > #ifdef TARGET_NR_madvise > case TARGET_NR_madvise: > /* A straight passthrough may not be safe because qemu sometimes Who is this realization make happy? --=20 Regards, Kirill A. Shutemov + Belarus, Minsk + ALT Linux Team, http://www.altlinux.com/ --RnlQjJ0d97Da+TV1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkjTWYIACgkQbWYnhzC5v6p8qQCeO7EZoWFvqZ0emFuAYc8rxMmW mzIAnRL50QGYraY4981nGDXrAr53S7hq =4NRm -----END PGP SIGNATURE----- --RnlQjJ0d97Da+TV1--