From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KgeNK-0002Me-E8 for qemu-devel@nongnu.org; Fri, 19 Sep 2008 07:42:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KgeNJ-0002Lm-FE for qemu-devel@nongnu.org; Fri, 19 Sep 2008 07:42:14 -0400 Received: from [199.232.76.173] (port=40463 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KgeNJ-0002LV-1Q for qemu-devel@nongnu.org; Fri, 19 Sep 2008 07:42:13 -0400 Received: from ik-out-1112.google.com ([66.249.90.176]:51848) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KgeNH-0005pM-8c for qemu-devel@nongnu.org; Fri, 19 Sep 2008 07:42:12 -0400 Received: by ik-out-1112.google.com with SMTP id c21so251809ika.2 for ; Fri, 19 Sep 2008 04:42:09 -0700 (PDT) Date: Fri, 19 Sep 2008 14:42:55 +0300 From: "Kirill A. Shutemov" Subject: Re: [Qemu-devel] [PATCH] qdd fadvise64_64 syscall Message-ID: <20080919114253.GA5346@localhost.localdomain> References: <20080917194528.GA21187@kos.to> <20080919074922.GA18614@localhost.localdomain> <20080919113205.GA9668@kos.to> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7JfCtLOvnd9MIVvH" Content-Disposition: inline In-Reply-To: <20080919113205.GA9668@kos.to> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org --7JfCtLOvnd9MIVvH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 19, 2008 at 02:32:05PM +0300, Riku Voipio wrote: > On Fri, Sep 19, 2008 at 10:49:24AM +0300, Kirill A. Shutemov wrote: > > On Wed, Sep 17, 2008 at 10:45:28PM +0300, Riku Voipio wrote: > > > Since it's only a hint, we can just add a happy passwtrough. Also > > > from scratchbox. > > >=20 > > > Signed-off-by: Riku Voipio > > > --=20 > > > "rm -rf" only sounds scary if you don't have backups > >=20 > > > Index: trunk/linux-user/arm/syscall_nr.h > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > --- trunk.orig/linux-user/arm/syscall_nr.h 2008-09-07 02:32:28.000000= 000 +0300 > > > +++ trunk/linux-user/arm/syscall_nr.h 2008-09-17 22:08:04.000000000 += 0300 > > > @@ -273,6 +273,7 @@ > > > #define TARGET_NR_fstatfs64 267 > > > #define TARGET_NR_tgkill 268 > > > #define TARGET_NR_utimes 269 > > > +#define TARGET_NR_fadvise64_64 270 > > > #define TARGET_NR_arm_fadvise64_64 270 > > > #define TARGET_NR_pciconfig_iobase 271 > > > #define TARGET_NR_pciconfig_read 272 >=20 > > It's wrong. > > ARM doesn't provide fadvise64_64 syscall. It provides arm_fadvise64_64 > > with different argument order. >=20 > In this case, it doesn't matter since we don't use the arguments. It matters if someone will provide true implementation of the syscall. > Nevertheless it's decepting and I'll remove it. >=20 > > > Index: trunk/linux-user/syscall.c > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > --- trunk.orig/linux-user/syscall.c 2008-09-17 21:43:47.000000000 +03= 00 > > > +++ trunk/linux-user/syscall.c 2008-09-17 22:08:51.000000000 +0300 > > > @@ -5532,6 +5532,12 @@ > > > } > > > break; > > > #endif > > > +#ifdef TARGET_NR_fadvise64_64 > > > + case TARGET_NR_fadvise64_64: > > > + /* This is a hint, so ignoring and returning success is ok. = */ > > > + ret =3D get_errno(0); > > > + break; > > > +#endif > > > #ifdef TARGET_NR_madvise > > > case TARGET_NR_madvise: > > > /* A straight passthrough may not be safe because qemu somet= imes >=20 > > Who is this realization make happy? >=20 > EPARSE. >=20 >=20 > --=20 > "rm -rf" only sounds scary if you don't have backups >=20 >=20 --=20 Regards, Kirill A. Shutemov + Belarus, Minsk + ALT Linux Team, http://www.altlinux.com/ --7JfCtLOvnd9MIVvH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkjTkD0ACgkQbWYnhzC5v6ouVgCeOyYNwyOvd3obEMpfwrKeALgy XkEAninNa83LIFPGwp/etfvWmhAqysvD =Tj52 -----END PGP SIGNATURE----- --7JfCtLOvnd9MIVvH--