Re: [Qemu-devel] [PATCH] Add mincore syscall

["Kirill A. Shutemov" <kirill@shutemov.name>]

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

On Fri, Sep 19, 2008 at 04:33:18PM +0300, Riku Voipio wrote:
> 
> Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> ---
>  linux-user/syscall.c |   14 +++++++++++++-
>  1 files changed, 13 insertions(+), 1 deletions(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 8e6e735..cb75c94 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5574,7 +5574,19 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
>          goto unimplemented;
>  #ifdef TARGET_NR_mincore
>      case TARGET_NR_mincore:
> -        goto unimplemented;
> +        {
> +            void *a;
> +            ret = -TARGET_EFAULT;
> +            if (!(a = lock_user(VERIFY_READ, arg1,arg2, 0)))
> +                goto efault;
> +            if (!(p = lock_user_string(arg3)))
> +                goto mincore_fail;
> +            ret = get_errno(mincore(a, arg2, p));
> +            unlock_user(p, arg3, ret);
> +            mincore_fail:
> +            unlock_user(a, arg1, 0);
> +        }
> +        break;
>  #endif
>  #ifdef TARGET_NR_fadvise64_64
>       case TARGET_NR_fadvise64_64:

Looks good for me. Added to my patchset.

-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.com/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]