[Qemu-devel] [PATCH] Add fadvise64 stubs

[Qemu-devel] [PATCH] Add fadvise64 stubs

[Riku Voipio]

Since these are only hints, we happily fake them for now
to make applications not barf on ENOSYS.

Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
---
 linux-user/syscall.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 4cde5e8..8e6e735 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5576,6 +5576,18 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
     case TARGET_NR_mincore:
         goto unimplemented;
 #endif
+#ifdef TARGET_NR_fadvise64_64
+     case TARGET_NR_fadvise64_64:
+        /* This is a hint, so ignoring and returning success is ok.  */
+        ret = get_errno(0);
+        break;
+#endif
+#ifdef TARGET_NR_arm_fadvise64_64
+     case TARGET_NR_arm_fadvise64_64:
+        /* This is a hint, so ignoring and returning success is ok.  */
+        ret = get_errno(0);
+        break;
+#endif
 #ifdef TARGET_NR_madvise
     case TARGET_NR_madvise:
         /* A straight passthrough may not be safe because qemu sometimes
-- 
1.5.6.5


-- 
"rm -rf" only sounds scary if you don't have backups

[Qemu-devel] [PATCH] Add fadvise64 stubs

[Kirill A. Shutemov]

Since these are only hints, we happily fake them for now
to make applications not barf on ENOSYS.

Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
---
 linux-user/syscall.c |   19 +++++++++++++++++++
 1 files changed, 19 insertions(+), 0 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 56b4138..74e4998 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5509,6 +5509,25 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
     case TARGET_NR_mincore:
         goto unimplemented;
 #endif
+#ifdef TARGET_NR_arm_fadvise64_64
+    case TARGET_NR_arm_fadvise64_64:
+	{
+		/*
+		 * arm_fadvise64_64 looks like fadvise64_64 but
+		 * with different argument order
+		 */
+		abi_long temp;
+		temp = arg3;
+		arg3 = arg4;
+		arg4 = temp;
+	}
+#endif
+#ifdef TARGET_NR_fadvise64_64
+    case TARGET_NR_fadvise64_64:
+        /* This is a hint, so ignoring and returning success is ok.  */
+	ret = get_errno(0);
+	break;
+#endif
 #ifdef TARGET_NR_madvise
     case TARGET_NR_madvise:
         /* A straight passthrough may not be safe because qemu sometimes
-- 
1.5.6.5.GIT

[Qemu-devel] Re: [PATCH] Add fadvise64 stubs

[Riku Voipio]

On Fri, Sep 19, 2008 at 04:52:11PM +0300, Kirill A. Shutemov wrote:
> Since these are only hints, we happily fake them for now
> to make applications not barf on ENOSYS.
> 
> Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> ---
>  linux-user/syscall.c |   19 +++++++++++++++++++
>  1 files changed, 19 insertions(+), 0 deletions(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 56b4138..74e4998 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5509,6 +5509,25 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
>      case TARGET_NR_mincore:
>          goto unimplemented;
>  #endif
> +#ifdef TARGET_NR_arm_fadvise64_64
> +    case TARGET_NR_arm_fadvise64_64:
> +	{
> +		/*
> +		 * arm_fadvise64_64 looks like fadvise64_64 but
> +		 * with different argument order
> +		 */
> +		abi_long temp;
> +		temp = arg3;
> +		arg3 = arg4;
> +		arg4 = temp;
> +	}
> +#endif
> +#ifdef TARGET_NR_fadvise64_64
> +    case TARGET_NR_fadvise64_64:
> +        /* This is a hint, so ignoring and returning success is ok.  */
> +	ret = get_errno(0);
> +	break;
> +#endif
>  #ifdef TARGET_NR_madvise
>      case TARGET_NR_madvise:
>          /* A straight passthrough may not be safe because qemu sometimes

Mmmh, what happens if TARGET_NR_arm_fadvise64_64 is set but
TARGET_NR_fadvise64_64 isn't :)

-- 
"rm -rf" only sounds scary if you don't have backups

[Qemu-devel] Re: [PATCH] Add fadvise64 stubs

[Kirill A. Shutemov]

[-- Attachment #1: Type: text/plain, Size: 1714 bytes --]

On Sat, Sep 20, 2008 at 09:26:04PM +0300, Riku Voipio wrote:
> On Fri, Sep 19, 2008 at 04:52:11PM +0300, Kirill A. Shutemov wrote:
> > Since these are only hints, we happily fake them for now
> > to make applications not barf on ENOSYS.
> > 
> > Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> > Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> > ---
> >  linux-user/syscall.c |   19 +++++++++++++++++++
> >  1 files changed, 19 insertions(+), 0 deletions(-)
> > 
> > diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> > index 56b4138..74e4998 100644
> > --- a/linux-user/syscall.c
> > +++ b/linux-user/syscall.c
> > @@ -5509,6 +5509,25 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
> >      case TARGET_NR_mincore:
> >          goto unimplemented;
> >  #endif
> > +#ifdef TARGET_NR_arm_fadvise64_64
> > +    case TARGET_NR_arm_fadvise64_64:
> > +	{
> > +		/*
> > +		 * arm_fadvise64_64 looks like fadvise64_64 but
> > +		 * with different argument order
> > +		 */
> > +		abi_long temp;
> > +		temp = arg3;
> > +		arg3 = arg4;
> > +		arg4 = temp;
> > +	}
> > +#endif
> > +#ifdef TARGET_NR_fadvise64_64
> > +    case TARGET_NR_fadvise64_64:
> > +        /* This is a hint, so ignoring and returning success is ok.  */
> > +	ret = get_errno(0);
> > +	break;
> > +#endif
> >  #ifdef TARGET_NR_madvise
> >      case TARGET_NR_madvise:
> >          /* A straight passthrough may not be safe because qemu sometimes
> 
> Mmmh, what happens if TARGET_NR_arm_fadvise64_64 is set but
> TARGET_NR_fadvise64_64 isn't :)

Oops... I'll fix it.

-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.com/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[Qemu-devel] [PATCH] Add fadvise64 stubs

[Kirill A. Shutemov]

Since these are only hints, we happily fake them for now
to make applications not barf on ENOSYS.

Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
---
 linux-user/syscall.c |   21 +++++++++++++++++++++
 1 files changed, 21 insertions(+), 0 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 489f632..f9aab47 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5572,6 +5572,27 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
     case TARGET_NR_mincore:
         goto unimplemented;
 #endif
+#ifdef TARGET_NR_arm_fadvise64_64
+    case TARGET_NR_arm_fadvise64_64:
+	{
+		/*
+		 * arm_fadvise64_64 looks like fadvise64_64 but
+		 * with different argument order
+		 */
+		abi_long temp;
+		temp = arg3;
+		arg3 = arg4;
+		arg4 = temp;
+	}
+#endif
+#if defined(TARGET_NR_fadvise64_64) || defined(TARGET_NR_arm_fadvise64_64)
+#ifdef TARGET_NR_fadvise64_64
+    case TARGET_NR_fadvise64_64:
+#endif
+        /* This is a hint, so ignoring and returning success is ok.  */
+	ret = get_errno(0);
+	break;
+#endif
 #ifdef TARGET_NR_madvise
     case TARGET_NR_madvise:
         /* A straight passthrough may not be safe because qemu sometimes
-- 
1.5.6.5.GIT

[Qemu-devel] Re: [PATCH] Add fadvise64 stubs

[Riku Voipio]

On Sat, Sep 20, 2008 at 09:51:31PM +0300, Kirill A. Shutemov wrote:
> Since these are only hints, we happily fake them for now
> to make applications not barf on ENOSYS.
> 
> Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>

Ack.

> ---
>  linux-user/syscall.c |   21 +++++++++++++++++++++
>  1 files changed, 21 insertions(+), 0 deletions(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 489f632..f9aab47 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5572,6 +5572,27 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
>      case TARGET_NR_mincore:
>          goto unimplemented;
>  #endif
> +#ifdef TARGET_NR_arm_fadvise64_64
> +    case TARGET_NR_arm_fadvise64_64:
> +	{
> +		/*
> +		 * arm_fadvise64_64 looks like fadvise64_64 but
> +		 * with different argument order
> +		 */
> +		abi_long temp;
> +		temp = arg3;
> +		arg3 = arg4;
> +		arg4 = temp;
> +	}
> +#endif
> +#if defined(TARGET_NR_fadvise64_64) || defined(TARGET_NR_arm_fadvise64_64)
> +#ifdef TARGET_NR_fadvise64_64
> +    case TARGET_NR_fadvise64_64:
> +#endif
> +        /* This is a hint, so ignoring and returning success is ok.  */
> +	ret = get_errno(0);
> +	break;
> +#endif
>  #ifdef TARGET_NR_madvise
>      case TARGET_NR_madvise:
>          /* A straight passthrough may not be safe because qemu sometimes
> -- 
> 1.5.6.5.GIT

-- 
"rm -rf" only sounds scary if you don't have backups

Re: [Qemu-devel] [PATCH] Add fadvise64 stubs

[Aurelien Jarno]

On Sat, Sep 20, 2008 at 09:51:31PM +0300, Kirill A. Shutemov wrote:
> Since these are only hints, we happily fake them for now
> to make applications not barf on ENOSYS.

Applied, thanks.

> Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> ---
>  linux-user/syscall.c |   21 +++++++++++++++++++++
>  1 files changed, 21 insertions(+), 0 deletions(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 489f632..f9aab47 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5572,6 +5572,27 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
>      case TARGET_NR_mincore:
>          goto unimplemented;
>  #endif
> +#ifdef TARGET_NR_arm_fadvise64_64
> +    case TARGET_NR_arm_fadvise64_64:
> +	{
> +		/*
> +		 * arm_fadvise64_64 looks like fadvise64_64 but
> +		 * with different argument order
> +		 */
> +		abi_long temp;
> +		temp = arg3;
> +		arg3 = arg4;
> +		arg4 = temp;
> +	}
> +#endif
> +#if defined(TARGET_NR_fadvise64_64) || defined(TARGET_NR_arm_fadvise64_64)
> +#ifdef TARGET_NR_fadvise64_64
> +    case TARGET_NR_fadvise64_64:
> +#endif
> +        /* This is a hint, so ignoring and returning success is ok.  */
> +	ret = get_errno(0);
> +	break;
> +#endif
>  #ifdef TARGET_NR_madvise
>      case TARGET_NR_madvise:
>          /* A straight passthrough may not be safe because qemu sometimes
> -- 
> 1.5.6.5.GIT
> 
> 
> 
> 

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net