From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kh79q-0005vc-Oa
	for qemu-devel@nongnu.org; Sat, 20 Sep 2008 14:26:14 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kh79o-0005tH-G7
	for qemu-devel@nongnu.org; Sat, 20 Sep 2008 14:26:13 -0400
Received: from [199.232.76.173] (port=50726 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kh79o-0005t5-C1
	for qemu-devel@nongnu.org; Sat, 20 Sep 2008 14:26:12 -0400
Received: from [84.20.150.76] (port=43318 helo=narury.org)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <nchip@kos.to>) id 1Kh79o-0002EF-Au
	for qemu-devel@nongnu.org; Sat, 20 Sep 2008 14:26:12 -0400
Date: Sat, 20 Sep 2008 21:26:04 +0300
From: Riku Voipio <riku.voipio@iki.fi>
Message-ID: <20080920182603.GA23970@kos.to>
References: <20080919133313.GA19874@kos.to>
	<1221832331-22637-1-git-send-email-kirill@shutemov.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1221832331-22637-1-git-send-email-kirill@shutemov.name>
Subject: [Qemu-devel] Re: [PATCH] Add fadvise64 stubs
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: qemu-devel@nongnu.org

On Fri, Sep 19, 2008 at 04:52:11PM +0300, Kirill A. Shutemov wrote:
> Since these are only hints, we happily fake them for now
> to make applications not barf on ENOSYS.
> 
> Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> ---
>  linux-user/syscall.c |   19 +++++++++++++++++++
>  1 files changed, 19 insertions(+), 0 deletions(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 56b4138..74e4998 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5509,6 +5509,25 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
>      case TARGET_NR_mincore:
>          goto unimplemented;
>  #endif
> +#ifdef TARGET_NR_arm_fadvise64_64
> +    case TARGET_NR_arm_fadvise64_64:
> +	{
> +		/*
> +		 * arm_fadvise64_64 looks like fadvise64_64 but
> +		 * with different argument order
> +		 */
> +		abi_long temp;
> +		temp = arg3;
> +		arg3 = arg4;
> +		arg4 = temp;
> +	}
> +#endif
> +#ifdef TARGET_NR_fadvise64_64
> +    case TARGET_NR_fadvise64_64:
> +        /* This is a hint, so ignoring and returning success is ok.  */
> +	ret = get_errno(0);
> +	break;
> +#endif
>  #ifdef TARGET_NR_madvise
>      case TARGET_NR_madvise:
>          /* A straight passthrough may not be safe because qemu sometimes

Mmmh, what happens if TARGET_NR_arm_fadvise64_64 is set but
TARGET_NR_fadvise64_64 isn't :)

-- 
"rm -rf" only sounds scary if you don't have backups