[Qemu-devel] Re: [PATCH] Add fadvise64 stubs

["Kirill A. Shutemov" <kirill@shutemov.name>]

[-- Attachment #1: Type: text/plain, Size: 1714 bytes --]

On Sat, Sep 20, 2008 at 09:26:04PM +0300, Riku Voipio wrote:
> On Fri, Sep 19, 2008 at 04:52:11PM +0300, Kirill A. Shutemov wrote:
> > Since these are only hints, we happily fake them for now
> > to make applications not barf on ENOSYS.
> > 
> > Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> > Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> > ---
> >  linux-user/syscall.c |   19 +++++++++++++++++++
> >  1 files changed, 19 insertions(+), 0 deletions(-)
> > 
> > diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> > index 56b4138..74e4998 100644
> > --- a/linux-user/syscall.c
> > +++ b/linux-user/syscall.c
> > @@ -5509,6 +5509,25 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
> >      case TARGET_NR_mincore:
> >          goto unimplemented;
> >  #endif
> > +#ifdef TARGET_NR_arm_fadvise64_64
> > +    case TARGET_NR_arm_fadvise64_64:
> > +	{
> > +		/*
> > +		 * arm_fadvise64_64 looks like fadvise64_64 but
> > +		 * with different argument order
> > +		 */
> > +		abi_long temp;
> > +		temp = arg3;
> > +		arg3 = arg4;
> > +		arg4 = temp;
> > +	}
> > +#endif
> > +#ifdef TARGET_NR_fadvise64_64
> > +    case TARGET_NR_fadvise64_64:
> > +        /* This is a hint, so ignoring and returning success is ok.  */
> > +	ret = get_errno(0);
> > +	break;
> > +#endif
> >  #ifdef TARGET_NR_madvise
> >      case TARGET_NR_madvise:
> >          /* A straight passthrough may not be safe because qemu sometimes
> 
> Mmmh, what happens if TARGET_NR_arm_fadvise64_64 is set but
> TARGET_NR_fadvise64_64 isn't :)

Oops... I'll fix it.

-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.com/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]