From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kh7OM-0001cL-G5 for qemu-devel@nongnu.org; Sat, 20 Sep 2008 14:41:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kh7OL-0001bt-1D for qemu-devel@nongnu.org; Sat, 20 Sep 2008 14:41:14 -0400 Received: from [199.232.76.173] (port=51231 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kh7OK-0001bp-Mv for qemu-devel@nongnu.org; Sat, 20 Sep 2008 14:41:12 -0400 Received: from nf-out-0910.google.com ([64.233.182.188]:40198) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kh7OK-0006o2-HE for qemu-devel@nongnu.org; Sat, 20 Sep 2008 14:41:12 -0400 Received: by nf-out-0910.google.com with SMTP id b2so468755nfb.12 for ; Sat, 20 Sep 2008 11:41:11 -0700 (PDT) Date: Sat, 20 Sep 2008 21:41:58 +0300 From: "Kirill A. Shutemov" Message-ID: <20080920184155.GA27610@localhost.localdomain> References: <20080919133313.GA19874@kos.to> <1221832331-22637-1-git-send-email-kirill@shutemov.name> <20080920182603.GA23970@kos.to> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CE+1k2dSO48ffgeK" Content-Disposition: inline In-Reply-To: <20080920182603.GA23970@kos.to> Subject: [Qemu-devel] Re: [PATCH] Add fadvise64 stubs Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Riku Voipio Cc: qemu-devel@nongnu.org --CE+1k2dSO48ffgeK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 20, 2008 at 09:26:04PM +0300, Riku Voipio wrote: > On Fri, Sep 19, 2008 at 04:52:11PM +0300, Kirill A. Shutemov wrote: > > Since these are only hints, we happily fake them for now > > to make applications not barf on ENOSYS. > >=20 > > Signed-off-by: Riku Voipio > > Signed-off-by: Kirill A. Shutemov > > --- > > linux-user/syscall.c | 19 +++++++++++++++++++ > > 1 files changed, 19 insertions(+), 0 deletions(-) > >=20 > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > > index 56b4138..74e4998 100644 > > --- a/linux-user/syscall.c > > +++ b/linux-user/syscall.c > > @@ -5509,6 +5509,25 @@ abi_long do_syscall(void *cpu_env, int num, abi_= long arg1, > > case TARGET_NR_mincore: > > goto unimplemented; > > #endif > > +#ifdef TARGET_NR_arm_fadvise64_64 > > + case TARGET_NR_arm_fadvise64_64: > > + { > > + /* > > + * arm_fadvise64_64 looks like fadvise64_64 but > > + * with different argument order > > + */ > > + abi_long temp; > > + temp =3D arg3; > > + arg3 =3D arg4; > > + arg4 =3D temp; > > + } > > +#endif > > +#ifdef TARGET_NR_fadvise64_64 > > + case TARGET_NR_fadvise64_64: > > + /* This is a hint, so ignoring and returning success is ok. */ > > + ret =3D get_errno(0); > > + break; > > +#endif > > #ifdef TARGET_NR_madvise > > case TARGET_NR_madvise: > > /* A straight passthrough may not be safe because qemu sometim= es >=20 > Mmmh, what happens if TARGET_NR_arm_fadvise64_64 is set but > TARGET_NR_fadvise64_64 isn't :) Oops... I'll fix it. --=20 Regards, Kirill A. Shutemov + Belarus, Minsk + ALT Linux Team, http://www.altlinux.com/ --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkjVQ/MACgkQbWYnhzC5v6oNsACeKRpBTYuONflCgCEU25cm6Xaf IgQAn2OUWCWV9csUmGsAujk0Fb1nyWXF =ZW/d -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK--