* [Qemu-devel] [PATCH] Add fadvise64 stubs
@ 2008-09-19 13:33 Riku Voipio
2008-09-19 13:52 ` Kirill A. Shutemov
0 siblings, 1 reply; 7+ messages in thread
From: Riku Voipio @ 2008-09-19 13:33 UTC (permalink / raw)
To: qemu-devel
Since these are only hints, we happily fake them for now
to make applications not barf on ENOSYS.
Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
---
linux-user/syscall.c | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 4cde5e8..8e6e735 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5576,6 +5576,18 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
case TARGET_NR_mincore:
goto unimplemented;
#endif
+#ifdef TARGET_NR_fadvise64_64
+ case TARGET_NR_fadvise64_64:
+ /* This is a hint, so ignoring and returning success is ok. */
+ ret = get_errno(0);
+ break;
+#endif
+#ifdef TARGET_NR_arm_fadvise64_64
+ case TARGET_NR_arm_fadvise64_64:
+ /* This is a hint, so ignoring and returning success is ok. */
+ ret = get_errno(0);
+ break;
+#endif
#ifdef TARGET_NR_madvise
case TARGET_NR_madvise:
/* A straight passthrough may not be safe because qemu sometimes
--
1.5.6.5
--
"rm -rf" only sounds scary if you don't have backups
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Qemu-devel] [PATCH] Add fadvise64 stubs
2008-09-19 13:33 [Qemu-devel] [PATCH] Add fadvise64 stubs Riku Voipio
@ 2008-09-19 13:52 ` Kirill A. Shutemov
2008-09-20 18:26 ` [Qemu-devel] " Riku Voipio
0 siblings, 1 reply; 7+ messages in thread
From: Kirill A. Shutemov @ 2008-09-19 13:52 UTC (permalink / raw)
To: qemu-devel; +Cc: Kirill A. Shutemov, Riku Voipio
Since these are only hints, we happily fake them for now
to make applications not barf on ENOSYS.
Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
---
linux-user/syscall.c | 19 +++++++++++++++++++
1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 56b4138..74e4998 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5509,6 +5509,25 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
case TARGET_NR_mincore:
goto unimplemented;
#endif
+#ifdef TARGET_NR_arm_fadvise64_64
+ case TARGET_NR_arm_fadvise64_64:
+ {
+ /*
+ * arm_fadvise64_64 looks like fadvise64_64 but
+ * with different argument order
+ */
+ abi_long temp;
+ temp = arg3;
+ arg3 = arg4;
+ arg4 = temp;
+ }
+#endif
+#ifdef TARGET_NR_fadvise64_64
+ case TARGET_NR_fadvise64_64:
+ /* This is a hint, so ignoring and returning success is ok. */
+ ret = get_errno(0);
+ break;
+#endif
#ifdef TARGET_NR_madvise
case TARGET_NR_madvise:
/* A straight passthrough may not be safe because qemu sometimes
--
1.5.6.5.GIT
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Qemu-devel] Re: [PATCH] Add fadvise64 stubs
2008-09-19 13:52 ` Kirill A. Shutemov
@ 2008-09-20 18:26 ` Riku Voipio
2008-09-20 18:41 ` Kirill A. Shutemov
2008-09-20 18:51 ` [Qemu-devel] " Kirill A. Shutemov
0 siblings, 2 replies; 7+ messages in thread
From: Riku Voipio @ 2008-09-20 18:26 UTC (permalink / raw)
To: Kirill A. Shutemov; +Cc: qemu-devel
On Fri, Sep 19, 2008 at 04:52:11PM +0300, Kirill A. Shutemov wrote:
> Since these are only hints, we happily fake them for now
> to make applications not barf on ENOSYS.
>
> Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> ---
> linux-user/syscall.c | 19 +++++++++++++++++++
> 1 files changed, 19 insertions(+), 0 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 56b4138..74e4998 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5509,6 +5509,25 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
> case TARGET_NR_mincore:
> goto unimplemented;
> #endif
> +#ifdef TARGET_NR_arm_fadvise64_64
> + case TARGET_NR_arm_fadvise64_64:
> + {
> + /*
> + * arm_fadvise64_64 looks like fadvise64_64 but
> + * with different argument order
> + */
> + abi_long temp;
> + temp = arg3;
> + arg3 = arg4;
> + arg4 = temp;
> + }
> +#endif
> +#ifdef TARGET_NR_fadvise64_64
> + case TARGET_NR_fadvise64_64:
> + /* This is a hint, so ignoring and returning success is ok. */
> + ret = get_errno(0);
> + break;
> +#endif
> #ifdef TARGET_NR_madvise
> case TARGET_NR_madvise:
> /* A straight passthrough may not be safe because qemu sometimes
Mmmh, what happens if TARGET_NR_arm_fadvise64_64 is set but
TARGET_NR_fadvise64_64 isn't :)
--
"rm -rf" only sounds scary if you don't have backups
^ permalink raw reply [flat|nested] 7+ messages in thread* [Qemu-devel] Re: [PATCH] Add fadvise64 stubs
2008-09-20 18:26 ` [Qemu-devel] " Riku Voipio
@ 2008-09-20 18:41 ` Kirill A. Shutemov
2008-09-20 18:51 ` [Qemu-devel] " Kirill A. Shutemov
1 sibling, 0 replies; 7+ messages in thread
From: Kirill A. Shutemov @ 2008-09-20 18:41 UTC (permalink / raw)
To: Riku Voipio; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1714 bytes --]
On Sat, Sep 20, 2008 at 09:26:04PM +0300, Riku Voipio wrote:
> On Fri, Sep 19, 2008 at 04:52:11PM +0300, Kirill A. Shutemov wrote:
> > Since these are only hints, we happily fake them for now
> > to make applications not barf on ENOSYS.
> >
> > Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> > Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> > ---
> > linux-user/syscall.c | 19 +++++++++++++++++++
> > 1 files changed, 19 insertions(+), 0 deletions(-)
> >
> > diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> > index 56b4138..74e4998 100644
> > --- a/linux-user/syscall.c
> > +++ b/linux-user/syscall.c
> > @@ -5509,6 +5509,25 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
> > case TARGET_NR_mincore:
> > goto unimplemented;
> > #endif
> > +#ifdef TARGET_NR_arm_fadvise64_64
> > + case TARGET_NR_arm_fadvise64_64:
> > + {
> > + /*
> > + * arm_fadvise64_64 looks like fadvise64_64 but
> > + * with different argument order
> > + */
> > + abi_long temp;
> > + temp = arg3;
> > + arg3 = arg4;
> > + arg4 = temp;
> > + }
> > +#endif
> > +#ifdef TARGET_NR_fadvise64_64
> > + case TARGET_NR_fadvise64_64:
> > + /* This is a hint, so ignoring and returning success is ok. */
> > + ret = get_errno(0);
> > + break;
> > +#endif
> > #ifdef TARGET_NR_madvise
> > case TARGET_NR_madvise:
> > /* A straight passthrough may not be safe because qemu sometimes
>
> Mmmh, what happens if TARGET_NR_arm_fadvise64_64 is set but
> TARGET_NR_fadvise64_64 isn't :)
Oops... I'll fix it.
--
Regards, Kirill A. Shutemov
+ Belarus, Minsk
+ ALT Linux Team, http://www.altlinux.com/
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* [Qemu-devel] [PATCH] Add fadvise64 stubs
2008-09-20 18:26 ` [Qemu-devel] " Riku Voipio
2008-09-20 18:41 ` Kirill A. Shutemov
@ 2008-09-20 18:51 ` Kirill A. Shutemov
2008-09-20 19:01 ` [Qemu-devel] " Riku Voipio
2008-10-01 21:49 ` [Qemu-devel] " Aurelien Jarno
1 sibling, 2 replies; 7+ messages in thread
From: Kirill A. Shutemov @ 2008-09-20 18:51 UTC (permalink / raw)
To: qemu-devel; +Cc: Kirill A. Shutemov, Riku Voipio
Since these are only hints, we happily fake them for now
to make applications not barf on ENOSYS.
Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
---
linux-user/syscall.c | 21 +++++++++++++++++++++
1 files changed, 21 insertions(+), 0 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 489f632..f9aab47 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5572,6 +5572,27 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
case TARGET_NR_mincore:
goto unimplemented;
#endif
+#ifdef TARGET_NR_arm_fadvise64_64
+ case TARGET_NR_arm_fadvise64_64:
+ {
+ /*
+ * arm_fadvise64_64 looks like fadvise64_64 but
+ * with different argument order
+ */
+ abi_long temp;
+ temp = arg3;
+ arg3 = arg4;
+ arg4 = temp;
+ }
+#endif
+#if defined(TARGET_NR_fadvise64_64) || defined(TARGET_NR_arm_fadvise64_64)
+#ifdef TARGET_NR_fadvise64_64
+ case TARGET_NR_fadvise64_64:
+#endif
+ /* This is a hint, so ignoring and returning success is ok. */
+ ret = get_errno(0);
+ break;
+#endif
#ifdef TARGET_NR_madvise
case TARGET_NR_madvise:
/* A straight passthrough may not be safe because qemu sometimes
--
1.5.6.5.GIT
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Qemu-devel] Re: [PATCH] Add fadvise64 stubs
2008-09-20 18:51 ` [Qemu-devel] " Kirill A. Shutemov
@ 2008-09-20 19:01 ` Riku Voipio
2008-10-01 21:49 ` [Qemu-devel] " Aurelien Jarno
1 sibling, 0 replies; 7+ messages in thread
From: Riku Voipio @ 2008-09-20 19:01 UTC (permalink / raw)
To: Kirill A. Shutemov; +Cc: qemu-devel
On Sat, Sep 20, 2008 at 09:51:31PM +0300, Kirill A. Shutemov wrote:
> Since these are only hints, we happily fake them for now
> to make applications not barf on ENOSYS.
>
> Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
Ack.
> ---
> linux-user/syscall.c | 21 +++++++++++++++++++++
> 1 files changed, 21 insertions(+), 0 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 489f632..f9aab47 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5572,6 +5572,27 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
> case TARGET_NR_mincore:
> goto unimplemented;
> #endif
> +#ifdef TARGET_NR_arm_fadvise64_64
> + case TARGET_NR_arm_fadvise64_64:
> + {
> + /*
> + * arm_fadvise64_64 looks like fadvise64_64 but
> + * with different argument order
> + */
> + abi_long temp;
> + temp = arg3;
> + arg3 = arg4;
> + arg4 = temp;
> + }
> +#endif
> +#if defined(TARGET_NR_fadvise64_64) || defined(TARGET_NR_arm_fadvise64_64)
> +#ifdef TARGET_NR_fadvise64_64
> + case TARGET_NR_fadvise64_64:
> +#endif
> + /* This is a hint, so ignoring and returning success is ok. */
> + ret = get_errno(0);
> + break;
> +#endif
> #ifdef TARGET_NR_madvise
> case TARGET_NR_madvise:
> /* A straight passthrough may not be safe because qemu sometimes
> --
> 1.5.6.5.GIT
--
"rm -rf" only sounds scary if you don't have backups
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH] Add fadvise64 stubs
2008-09-20 18:51 ` [Qemu-devel] " Kirill A. Shutemov
2008-09-20 19:01 ` [Qemu-devel] " Riku Voipio
@ 2008-10-01 21:49 ` Aurelien Jarno
1 sibling, 0 replies; 7+ messages in thread
From: Aurelien Jarno @ 2008-10-01 21:49 UTC (permalink / raw)
To: qemu-devel; +Cc: Kirill A. Shutemov, Riku Voipio
On Sat, Sep 20, 2008 at 09:51:31PM +0300, Kirill A. Shutemov wrote:
> Since these are only hints, we happily fake them for now
> to make applications not barf on ENOSYS.
Applied, thanks.
> Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> ---
> linux-user/syscall.c | 21 +++++++++++++++++++++
> 1 files changed, 21 insertions(+), 0 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 489f632..f9aab47 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5572,6 +5572,27 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
> case TARGET_NR_mincore:
> goto unimplemented;
> #endif
> +#ifdef TARGET_NR_arm_fadvise64_64
> + case TARGET_NR_arm_fadvise64_64:
> + {
> + /*
> + * arm_fadvise64_64 looks like fadvise64_64 but
> + * with different argument order
> + */
> + abi_long temp;
> + temp = arg3;
> + arg3 = arg4;
> + arg4 = temp;
> + }
> +#endif
> +#if defined(TARGET_NR_fadvise64_64) || defined(TARGET_NR_arm_fadvise64_64)
> +#ifdef TARGET_NR_fadvise64_64
> + case TARGET_NR_fadvise64_64:
> +#endif
> + /* This is a hint, so ignoring and returning success is ok. */
> + ret = get_errno(0);
> + break;
> +#endif
> #ifdef TARGET_NR_madvise
> case TARGET_NR_madvise:
> /* A straight passthrough may not be safe because qemu sometimes
> --
> 1.5.6.5.GIT
>
>
>
>
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-10-01 21:49 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-19 13:33 [Qemu-devel] [PATCH] Add fadvise64 stubs Riku Voipio
2008-09-19 13:52 ` Kirill A. Shutemov
2008-09-20 18:26 ` [Qemu-devel] " Riku Voipio
2008-09-20 18:41 ` Kirill A. Shutemov
2008-09-20 18:51 ` [Qemu-devel] " Kirill A. Shutemov
2008-09-20 19:01 ` [Qemu-devel] " Riku Voipio
2008-10-01 21:49 ` [Qemu-devel] " Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).