From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KhOX7-0001tO-0C
	for qemu-devel@nongnu.org; Sun, 21 Sep 2008 08:59:25 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KhOX4-0001t0-LF
	for qemu-devel@nongnu.org; Sun, 21 Sep 2008 08:59:23 -0400
Received: from [199.232.76.173] (port=42320 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KhOX4-0001sx-Eh
	for qemu-devel@nongnu.org; Sun, 21 Sep 2008 08:59:22 -0400
Received: from mail.codesourcery.com ([65.74.133.4]:34130)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1KhOX3-0005pz-SY
	for qemu-devel@nongnu.org; Sun, 21 Sep 2008 08:59:22 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Add uselib syscall
Date: Sun, 21 Sep 2008 13:59:11 +0100
References: <20080919133327.GA19898@kos.to>
In-Reply-To: <20080919133327.GA19898@kos.to>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200809211359.11580.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>

>      case TARGET_NR_uselib:
> -        goto unimplemented;
> +        {
> +            if(!(p = lock_user_string(arg1))) {
> +                ret = -TARGET_EFAULT;
> +                goto efault;
> +            }
> +            ret = get_errno(uselib(path(p)));
> +            unlock_user(p, arg1, 0);
> +        }
> +        break;

I'm pretty sure this is wrong. The last thing we want to be doing is loading a 
host library.

Paul