From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KhPU8-0002hh-Tt
	for qemu-devel@nongnu.org; Sun, 21 Sep 2008 10:00:24 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KhPU7-0002hU-Jd
	for qemu-devel@nongnu.org; Sun, 21 Sep 2008 10:00:24 -0400
Received: from [199.232.76.173] (port=38302 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KhPU7-0002hR-Db
	for qemu-devel@nongnu.org; Sun, 21 Sep 2008 10:00:23 -0400
Received: from ey-out-1920.google.com ([74.125.78.149]:65031)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kirill@shutemov.name>) id 1KhPU6-0007b4-Ur
	for qemu-devel@nongnu.org; Sun, 21 Sep 2008 10:00:23 -0400
Received: by ey-out-1920.google.com with SMTP id 4so291739eyk.4
	for <qemu-devel@nongnu.org>; Sun, 21 Sep 2008 07:00:21 -0700 (PDT)
Date: Sun, 21 Sep 2008 17:01:09 +0300
From: "Kirill A. Shutemov" <kirill@shutemov.name>
Subject: Re: [Qemu-devel] [PATCH] Add readahead syscall
Message-ID: <20080921140108.GA20056@localhost.localdomain>
References: <20080919133323.GA19890@kos.to>
	<200809211403.16987.paul@codesourcery.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="BOKacYhQ+x31HxR3"
Content-Disposition: inline
In-Reply-To: <200809211403.16987.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>


--BOKacYhQ+x31HxR3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Sep 21, 2008 at 02:03:16PM +0100, Paul Brook wrote:
> >  #ifdef TARGET_NR_readahead
> >      case TARGET_NR_readahead:
> > -        goto unimplemented;
> > +        ret =3D get_errno(readahead(arg1, arg2, arg3));
> > +        break;
>=20
> This is wrong on 32-bit targets, and especially wrong on ARM where there =
are=20
> two variants.

Two variants?

$ git grep readahead arch/arm/include/asm/unistd.h
arch/arm/include/asm/unistd.h:#define __NR_readahead (__NR_SYSCALL_BASE+225)

--=20
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.com/

--BOKacYhQ+x31HxR3
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkjWU6QACgkQbWYnhzC5v6rY9ACgiYUgtg3T8XbeULWSbac7jE0J
FqsAnjgNFMBg+baL5Nes6T0Btf+6XBtN
=XUhV
-----END PGP SIGNATURE-----

--BOKacYhQ+x31HxR3--