From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KhPdB-0006Be-UC
	for qemu-devel@nongnu.org; Sun, 21 Sep 2008 10:09:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KhPdA-0006A2-0d
	for qemu-devel@nongnu.org; Sun, 21 Sep 2008 10:09:45 -0400
Received: from [199.232.76.173] (port=54234 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KhPd9-00069q-SY
	for qemu-devel@nongnu.org; Sun, 21 Sep 2008 10:09:43 -0400
Received: from mail.codesourcery.com ([65.74.133.4]:59531)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1KhPd9-0001Yd-Eq
	for qemu-devel@nongnu.org; Sun, 21 Sep 2008 10:09:43 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Add readahead syscall
Date: Sun, 21 Sep 2008 15:09:38 +0100
References: <20080919133323.GA19890@kos.to>
	<200809211403.16987.paul@codesourcery.com>
	<20080921140108.GA20056@localhost.localdomain>
In-Reply-To: <20080921140108.GA20056@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200809211509.39183.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>, Riku Voipio <riku.voipio@iki.fi>

On Sunday 21 September 2008, Kirill A. Shutemov wrote:
> On Sun, Sep 21, 2008 at 02:03:16PM +0100, Paul Brook wrote:
> > >  #ifdef TARGET_NR_readahead
> > >      case TARGET_NR_readahead:
> > > -        goto unimplemented;
> > > +        ret = get_errno(readahead(arg1, arg2, arg3));
> > > +        break;
> >
> > This is wrong on 32-bit targets, and especially wrong on ARM where there
> > are two variants.
>
> Two variants?

EABI and old-abi.

Paul