From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KhS0X-00058u-1m
	for qemu-devel@nongnu.org; Sun, 21 Sep 2008 12:42:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KhS0V-00058I-9W
	for qemu-devel@nongnu.org; Sun, 21 Sep 2008 12:42:00 -0400
Received: from [199.232.76.173] (port=43486 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KhS0V-00058C-4b
	for qemu-devel@nongnu.org; Sun, 21 Sep 2008 12:41:59 -0400
Received: from mail.codesourcery.com ([65.74.133.4]:55023)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1KhS0U-0003R9-F7
	for qemu-devel@nongnu.org; Sun, 21 Sep 2008 12:41:59 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [5281] Use the new concat_i32_i64 op for std and stda
Date: Sun, 21 Sep 2008 17:41:53 +0100
References: <E1KhQFJ-0006tS-Ib@cvs.savannah.gnu.org>
	<f43fc5580809210908g62651ae4q2c876f55fbb9d299@mail.gmail.com>
	<f43fc5580809210929x3c70a9a1s5a11b2bdb1d98e65@mail.gmail.com>
In-Reply-To: <f43fc5580809210929x3c70a9a1s5a11b2bdb1d98e65@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200809211741.53544.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>

> Like these patches?

> +static inline void tcg_gen_concat_i64_i64(TCGv dest, TCGv low, TCGv high)
> +{
> +    TCGv tmp = tcg_temp_new(TCG_TYPE_I64);
> +    tcg_gen_shli_i64(tmp, high, 32);
> +    tcg_gen_or_i64(dest, low, tmp);
> +    tcg_temp_free(tmp);
> +}

This should use concat_i32_i64 on 32-bit hosts.

Ok with that change, the rename I suggested in my previous mail, and if you 
add documentation to tcg/README.

Paul