From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ki3h2-0006Of-GH for qemu-devel@nongnu.org; Tue, 23 Sep 2008 04:56:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ki3h0-0006OR-Ra for qemu-devel@nongnu.org; Tue, 23 Sep 2008 04:56:24 -0400 Received: from [199.232.76.173] (port=36040 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ki3h0-0006OO-Nc for qemu-devel@nongnu.org; Tue, 23 Sep 2008 04:56:22 -0400 Received: from mta23.gyao.ne.jp ([125.63.38.249]:38296 helo=mx.gate01.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ki3h0-0001g8-4M for qemu-devel@nongnu.org; Tue, 23 Sep 2008 04:56:22 -0400 Received: from [124.34.33.190] (helo=master.linux-sh.org) by pop55.isp.us-com.jp with esmtp (Mail 4.69) id 1Ki3gv-0006um-SV for qemu-devel@nongnu.org; Tue, 23 Sep 2008 17:56:17 +0900 Received: from localhost (unknown [127.0.0.1]) by master.linux-sh.org (Postfix) with ESMTP id 0FA4163754 for ; Tue, 23 Sep 2008 08:55:20 +0000 (UTC) Received: from master.linux-sh.org ([127.0.0.1]) by localhost (master.linux-sh.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eVdR8xMh0IPK for ; Tue, 23 Sep 2008 17:55:19 +0900 (JST) Date: Tue, 23 Sep 2008 17:55:19 +0900 From: Paul Mundt Subject: Re: [Qemu-devel] [PATCH] sh4: mmio based CF support on r2d board. Message-ID: <20080923085519.GA7603@linux-sh.org> References: <20080923013136.490117fd.yoshii.takashi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080923013136.490117fd.yoshii.takashi@gmail.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Tue, Sep 23, 2008 at 01:31:36AM +0900, yoshii.takashi@gmail.com wrote: > This patch adds emulation for a CompactFlash on sh4/r2d board. > I can mount/umount and some read/writes with r2d-1 kernel (no irq mode). > No heavy/formal test has not be done, though. > > The device is CF, but wired to be worked as True-IDE mode, and connected > directly to SH bus. So, this code is to supports generally mmio based IDEs > which are supported by "pata_platform" driver in linux kernel. > > I wonder where to put function prototype for mmio_ide_init(). > Currently, it is in r2d.c, but I believe it can be in more common place. > > Any suggestions? > ide.c is likely the best place for it. It looks like there is a bit of overlap with pmac_ide though. ARM and others that use pata_platform will want to use this as well.