From: Vince Weaver <vince@csl.cornell.edu>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5283] Use the new concat_tl_i64 op for std and stda
Date: Tue, 23 Sep 2008 18:08:42 -0400 (EDT) [thread overview]
Message-ID: <20080923180629.I10486@stanley.csl.cornell.edu> (raw)
In-Reply-To: <200809232259.24692.paul@codesourcery.com>
On Tue, 23 Sep 2008, Paul Brook wrote:
> On Tuesday 23 September 2008, Vince Weaver wrote:
>> Hello
>>
>> the aforementioned patch broke the spec2k crafty benchmark on
>> sparc32plus-linux-user (I'm running on x86_64 but I don't think it makes a
>> difference).
>
> Are you sure? I've double checked the patch and I still think it is correct.
Yes. The program definitely works if I revert the patch, but fails if I
re-apply it.
>> The new code generates:
>> movi_i64 tmp12,$0x20
>> shl_i64 tmp10,loc4,tmp12
>> or_i64 tmp2,tmp0,tmp10
>> qemu_st64 tmp2,loc5,$0x0
>
> The extension should be immediately before the code you quote here.
Nope, in both cases the preceeding code is identical:
OP after la:
movi_i64 tmp8,$0x13bc00
mov_i64 g1,tmp8
movi_i64 tmp10,$0x268
add_i64 loc5,g1,tmp10
ld_i64 loc4,regwptr,$0x0
movi_i64 pc,$0x27e78
movi_i64 npc,$0x27e7c
movi_i64 tmp10,$0xffffffff
and_i64 loc5,loc5,tmp10
movi_i32 tmp11,$0x7
movi_i64 tmp10,$helper_check_align
call tmp10,$0x0,$0,loc5,tmp11
ld_i64 tmp0,regwptr,$0x8
The code in question is:
IN: InitializeMasks
0x0000000000027e74: sethi %hi(0x13bc00), %g1
0x0000000000027e78: std %o0, [ %g1 + 0x268 ] ! 0x13be68
0x0000000000027e7c: call 0x22eac
0x0000000000027e80: mov 3, %o0
I can create a small assembly language program that duplicates the problem
if it would help debugging it.
Vince
next prev parent reply other threads:[~2008-09-23 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-23 21:49 [Qemu-devel] [5283] Use the new concat_tl_i64 op for std and stda Vince Weaver
2008-09-23 21:59 ` Paul Brook
2008-09-23 22:08 ` Vince Weaver [this message]
2008-09-23 22:31 ` Vince Weaver
2008-09-23 22:31 ` Paul Brook
-- strict thread matches above, loose matches on Subject: below --
2008-09-21 18:43 Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080923180629.I10486@stanley.csl.cornell.edu \
--to=vince@csl.cornell.edu \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).