From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KiFus-0001b2-Sk for qemu-devel@nongnu.org; Tue, 23 Sep 2008 17:59:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KiFur-0001ad-DF for qemu-devel@nongnu.org; Tue, 23 Sep 2008 17:59:30 -0400 Received: from [199.232.76.173] (port=52345 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KiFur-0001aa-8B for qemu-devel@nongnu.org; Tue, 23 Sep 2008 17:59:29 -0400 Received: from mail.codesourcery.com ([65.74.133.4]:53723) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KiFur-0008GQ-4k for qemu-devel@nongnu.org; Tue, 23 Sep 2008 17:59:29 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [5283] Use the new concat_tl_i64 op for std and stda Date: Tue, 23 Sep 2008 22:59:24 +0100 References: <20080923174506.X10311@stanley.csl.cornell.edu> In-Reply-To: <20080923174506.X10311@stanley.csl.cornell.edu> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200809232259.24692.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Tuesday 23 September 2008, Vince Weaver wrote: > Hello > > the aforementioned patch broke the spec2k crafty benchmark on > sparc32plus-linux-user (I'm running on x86_64 but I don't think it makes a > difference). Are you sure? I've double checked the patch and I still think it is correct. > > The new code generates: > movi_i64 tmp12,$0x20 > shl_i64 tmp10,loc4,tmp12 > or_i64 tmp2,tmp0,tmp10 > qemu_st64 tmp2,loc5,$0x0 The extension should be immediately before the code you quote here. Paul