From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KjvEy-0008W9-09
	for qemu-devel@nongnu.org; Sun, 28 Sep 2008 08:19:08 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KjvEw-0008Uh-AO
	for qemu-devel@nongnu.org; Sun, 28 Sep 2008 08:19:07 -0400
Received: from [199.232.76.173] (port=36991 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KjvEw-0008Ud-23
	for qemu-devel@nongnu.org; Sun, 28 Sep 2008 08:19:06 -0400
Received: from fg-out-1718.google.com ([72.14.220.153]:3024)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <makovick@gmail.com>) id 1KjvEv-0002o0-IQ
	for qemu-devel@nongnu.org; Sun, 28 Sep 2008 08:19:05 -0400
Received: by fg-out-1718.google.com with SMTP id l26so2122557fgb.8
	for <qemu-devel@nongnu.org>; Sun, 28 Sep 2008 05:19:03 -0700 (PDT)
Date: Sun, 28 Sep 2008 14:19:00 +0200
From: Jindrich Makovicka <makovick@gmail.com>
Message-ID: <20080928141900.02c50d72@holly>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] [PATCH] fix format string warning in block-vmdk.c
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hi,

total_size is an int64_t, so the format should be PRIi64.

Index: block-vmdk.c
===================================================================
--- block-vmdk.c        (revision 5338)
+++ block-vmdk.c        (working copy)
@@ -716,7 +716,7 @@
         "#DDB\n"
         "\n"
         "ddb.virtualHWVersion = \"%d\"\n"
-        "ddb.geometry.cylinders = \"%lu\"\n"
+        "ddb.geometry.cylinders = \"%" PRIi64 "\"\n"
         "ddb.geometry.heads = \"16\"\n"
         "ddb.geometry.sectors = \"63\"\n"
         "ddb.adapterType = \"ide\"\n";

Regards,
-- 
Jindrich Makovicka