[Qemu-devel] [PATCH] Fix cscope filelist by removing leading ./

[Qemu-devel] [PATCH] Fix cscope filelist by removing leading ./

[Ryan Harper]

When using cscope integrated in $EDITOR, none of the commands seemed to work
even though make cscope generated the proper data.  Comparing the filelist that
is generated in QEMU's Makefile with what is generated from the Linux kernel's
make cscope, I noticed that the kernel's cscope filelist does not contain any
leading './' as is generated by the find command used in QEMU's make cscope.
Stripping the leading ./ out of the filelist fixes cscope function in $EDITOR.

Signed-off-by: Ryan Harper <ryanh@us.ibm.com>

diff --git a/Makefile b/Makefile
index d57f791..cde8676 100644
--- a/Makefile
+++ b/Makefile
@@ -261,7 +261,7 @@ TAGS:
 
 cscope:
 	rm -f ./cscope.*
-	find . -name "*.[ch]" -print > ./cscope.files
+	find . -name "*.[ch]" -print | sed 's,./,,' > ./cscope.files
 	cscope -b
 
 # documentation

Re: [Qemu-devel] [PATCH] Fix cscope filelist by removing leading ./

[Andreas Schwab]

Ryan Harper <ryanh@us.ibm.com> writes:

> -	find . -name "*.[ch]" -print > ./cscope.files
> +	find . -name "*.[ch]" -print | sed 's,./,,' > ./cscope.files

This will also match 'a/'.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [Qemu-devel] [PATCH] Fix cscope filelist by removing leading ./

[Ryan Harper]

* Andreas Schwab <schwab@suse.de> [2008-10-01 10:23]:
> Ryan Harper <ryanh@us.ibm.com> writes:
> 
> > -	find . -name "*.[ch]" -print > ./cscope.files
> > +	find . -name "*.[ch]" -print | sed 's,./,,' > ./cscope.files
> 
> This will also match 'a/'.

Is there a case where the find command we're using would output
something without './' in the first to characters in each line where
that case would be an issue?

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253
ryanh@us.ibm.com

Re: [Qemu-devel] [PATCH] Fix cscope filelist by removing leading ./

[Laurent Desnogues]

On Wed, Oct 1, 2008 at 5:29 PM, Ryan Harper <ryanh@us.ibm.com> wrote:
> * Andreas Schwab <schwab@suse.de> [2008-10-01 10:23]:
>> Ryan Harper <ryanh@us.ibm.com> writes:
>>
>> > -   find . -name "*.[ch]" -print > ./cscope.files
>> > +   find . -name "*.[ch]" -print | sed 's,./,,' > ./cscope.files
>>
>> This will also match 'a/'.
>
> Is there a case where the find command we're using would output
> something without './' in the first to characters in each line where
> that case would be an issue?

Why not using  sed 's,^\./,,'?


Laurent

Re: [Qemu-devel] [PATCH] Fix cscope filelist by removing leading ./

[Aurelien Jarno]

On Wed, Oct 01, 2008 at 05:36:29PM +0200, Laurent Desnogues wrote:
> On Wed, Oct 1, 2008 at 5:29 PM, Ryan Harper <ryanh@us.ibm.com> wrote:
> > * Andreas Schwab <schwab@suse.de> [2008-10-01 10:23]:
> >> Ryan Harper <ryanh@us.ibm.com> writes:
> >>
> >> > -   find . -name "*.[ch]" -print > ./cscope.files
> >> > +   find . -name "*.[ch]" -print | sed 's,./,,' > ./cscope.files
> >>
> >> This will also match 'a/'.
> >
> > Is there a case where the find command we're using would output
> > something without './' in the first to characters in each line where
> > that case would be an issue?
> 
> Why not using  sed 's,^\./,,'?
> 

I applied this version, thanks.


-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net