From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kl9Xc-0008DZ-5S
	for qemu-devel@nongnu.org; Wed, 01 Oct 2008 17:47:28 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kl9Xb-0008DH-RL
	for qemu-devel@nongnu.org; Wed, 01 Oct 2008 17:47:27 -0400
Received: from [199.232.76.173] (port=47843 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kl9Xb-0008DB-JY
	for qemu-devel@nongnu.org; Wed, 01 Oct 2008 17:47:27 -0400
Received: from hall.aurel32.net ([88.191.82.174]:56272)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1Kl9Xb-0003PL-4F
	for qemu-devel@nongnu.org; Wed, 01 Oct 2008 17:47:27 -0400
Received: from volta.aurel32.net ([2002:52e8:2fb:1:21e:8cff:feb0:693b])
	by hall.aurel32.net with esmtpsa (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.63) (envelope-from <aurelien@aurel32.net>)
	id 1Kl9XZ-0002ny-Sz
	for qemu-devel@nongnu.org; Wed, 01 Oct 2008 23:47:25 +0200
Received: from aurel32 by volta.aurel32.net with local (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1Kl9XV-0001Ho-88
	for qemu-devel@nongnu.org; Wed, 01 Oct 2008 23:47:21 +0200
Date: Wed, 1 Oct 2008 23:47:21 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] ppc32 guests: fix computation of XER.{CA,
	OV} in addme, subfme, mullwo
Message-ID: <20081001214721.GB31270@volta.aurel32.net>
References: <200805110204.47184.jseward@acm.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <200805110204.47184.jseward@acm.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sun, May 11, 2008 at 02:04:47AM +0200, Julian Seward wrote:
> 
> For ppc32 guests, computation of XER.CA and XER.OV in some obscure
> cases is incorrect.  At least, it doesn't produce the same results
> as a real MPC7447, and doesn't appear to be in accordance with the
> instruction set documentation.
> 
> The attached patch fixes it:
> 
> * addme{o}{.}, subfme{o}{.}: compute XER.CA correctly
> 
> * mullwo{.}: sign extend arguments before doing 64-bit
>   multiply, so as to make the XER.OV computation correct
> 

I fixed both problems by applying a mix of your patch and of the patch
from Jocelyn Mayer.

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net