qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RESEND][PATCH] fix default size handling in monitor.
Date: Wed, 1 Oct 2008 23:47:53 +0200	[thread overview]
Message-ID: <20081001214753.GC31270@volta.aurel32.net> (raw)
In-Reply-To: <20080623085548.GB3028@minantech.com>

On Mon, Jun 23, 2008 at 11:55:48AM +0300, Gleb Natapov wrote:
> Hi,
> 
>   If /i format is used once (with x/xp/p command) default_fmt_size is set
> to -1 and subsequent commands of the form /x outputs nothing. Included
> patched fixes this by setting default_fmt_size only if the command is
> not of format /i.

Applied, thanks.

> Signed-off-by: Gleb Natapov <gleb@qumranet.com>
> ---
> diff --git a/monitor.c b/monitor.c
> index 1eb8be1..4df4d87 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2270,8 +2270,8 @@ static void monitor_handle_command(const char *cmdline)
>                          /* for 'i', not specifying a size gives -1 as size */
>                          if (size < 0)
>                              size = default_fmt_size;
> +                        default_fmt_size = size;
>                      }
> -                    default_fmt_size = size;
>                      default_fmt_format = format;
>                  } else {
>                      count = 1;
> 
> --
> 			Gleb.
> 
> 
> 

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

      reply	other threads:[~2008-10-01 21:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-23  8:55 [Qemu-devel] [RESEND][PATCH] fix default size handling in monitor Gleb Natapov
2008-10-01 21:47 ` Aurelien Jarno [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081001214753.GC31270@volta.aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).