From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kl9Y9-0008Pm-44
	for qemu-devel@nongnu.org; Wed, 01 Oct 2008 17:48:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kl9Y7-0008PG-Sr
	for qemu-devel@nongnu.org; Wed, 01 Oct 2008 17:48:00 -0400
Received: from [199.232.76.173] (port=47852 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kl9Y7-0008PD-Ob
	for qemu-devel@nongnu.org; Wed, 01 Oct 2008 17:47:59 -0400
Received: from hall.aurel32.net ([88.191.82.174]:56276)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1Kl9Y7-0003SL-5A
	for qemu-devel@nongnu.org; Wed, 01 Oct 2008 17:47:59 -0400
Received: from volta.aurel32.net ([2002:52e8:2fb:1:21e:8cff:feb0:693b])
	by hall.aurel32.net with esmtpsa (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.63) (envelope-from <aurelien@aurel32.net>)
	id 1Kl9Y5-0002o1-Rz
	for qemu-devel@nongnu.org; Wed, 01 Oct 2008 23:47:57 +0200
Received: from aurel32 by volta.aurel32.net with local (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1Kl9Y1-0001II-7T
	for qemu-devel@nongnu.org; Wed, 01 Oct 2008 23:47:53 +0200
Date: Wed, 1 Oct 2008 23:47:53 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [RESEND][PATCH] fix default size handling in monitor.
Message-ID: <20081001214753.GC31270@volta.aurel32.net>
References: <20080623085548.GB3028@minantech.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <20080623085548.GB3028@minantech.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Mon, Jun 23, 2008 at 11:55:48AM +0300, Gleb Natapov wrote:
> Hi,
> 
>   If /i format is used once (with x/xp/p command) default_fmt_size is set
> to -1 and subsequent commands of the form /x outputs nothing. Included
> patched fixes this by setting default_fmt_size only if the command is
> not of format /i.

Applied, thanks.

> Signed-off-by: Gleb Natapov <gleb@qumranet.com>
> ---
> diff --git a/monitor.c b/monitor.c
> index 1eb8be1..4df4d87 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2270,8 +2270,8 @@ static void monitor_handle_command(const char *cmdline)
>                          /* for 'i', not specifying a size gives -1 as size */
>                          if (size < 0)
>                              size = default_fmt_size;
> +                        default_fmt_size = size;
>                      }
> -                    default_fmt_size = size;
>                      default_fmt_format = format;
>                  } else {
>                      count = 1;
> 
> --
> 			Gleb.
> 
> 
> 

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net