* [Qemu-devel] [RESEND][PATCH] fix default size handling in monitor.
@ 2008-06-23 8:55 Gleb Natapov
2008-10-01 21:47 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Gleb Natapov @ 2008-06-23 8:55 UTC (permalink / raw)
To: qemu-devel
Hi,
If /i format is used once (with x/xp/p command) default_fmt_size is set
to -1 and subsequent commands of the form /x outputs nothing. Included
patched fixes this by setting default_fmt_size only if the command is
not of format /i.
Signed-off-by: Gleb Natapov <gleb@qumranet.com>
---
diff --git a/monitor.c b/monitor.c
index 1eb8be1..4df4d87 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2270,8 +2270,8 @@ static void monitor_handle_command(const char *cmdline)
/* for 'i', not specifying a size gives -1 as size */
if (size < 0)
size = default_fmt_size;
+ default_fmt_size = size;
}
- default_fmt_size = size;
default_fmt_format = format;
} else {
count = 1;
--
Gleb.
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [RESEND][PATCH] fix default size handling in monitor.
2008-06-23 8:55 [Qemu-devel] [RESEND][PATCH] fix default size handling in monitor Gleb Natapov
@ 2008-10-01 21:47 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2008-10-01 21:47 UTC (permalink / raw)
To: qemu-devel
On Mon, Jun 23, 2008 at 11:55:48AM +0300, Gleb Natapov wrote:
> Hi,
>
> If /i format is used once (with x/xp/p command) default_fmt_size is set
> to -1 and subsequent commands of the form /x outputs nothing. Included
> patched fixes this by setting default_fmt_size only if the command is
> not of format /i.
Applied, thanks.
> Signed-off-by: Gleb Natapov <gleb@qumranet.com>
> ---
> diff --git a/monitor.c b/monitor.c
> index 1eb8be1..4df4d87 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2270,8 +2270,8 @@ static void monitor_handle_command(const char *cmdline)
> /* for 'i', not specifying a size gives -1 as size */
> if (size < 0)
> size = default_fmt_size;
> + default_fmt_size = size;
> }
> - default_fmt_size = size;
> default_fmt_format = format;
> } else {
> count = 1;
>
> --
> Gleb.
>
>
>
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-01 21:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-23 8:55 [Qemu-devel] [RESEND][PATCH] fix default size handling in monitor Gleb Natapov
2008-10-01 21:47 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).