From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kl9ZU-0000SI-3J
	for qemu-devel@nongnu.org; Wed, 01 Oct 2008 17:49:24 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kl9ZS-0000Rv-MJ
	for qemu-devel@nongnu.org; Wed, 01 Oct 2008 17:49:22 -0400
Received: from [199.232.76.173] (port=47870 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kl9ZS-0000Rq-D0
	for qemu-devel@nongnu.org; Wed, 01 Oct 2008 17:49:22 -0400
Received: from hall.aurel32.net ([88.191.82.174]:39571)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1Kl9ZR-0003b1-SM
	for qemu-devel@nongnu.org; Wed, 01 Oct 2008 17:49:22 -0400
Date: Wed, 1 Oct 2008 23:49:15 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] Add fadvise64 stubs
Message-ID: <20081001214915.GE31270@volta.aurel32.net>
References: <20080920182603.GA23970@kos.to>
	<1221936691-27969-1-git-send-email-kirill@shutemov.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1221936691-27969-1-git-send-email-kirill@shutemov.name>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>, Riku Voipio <riku.voipio@iki.fi>

On Sat, Sep 20, 2008 at 09:51:31PM +0300, Kirill A. Shutemov wrote:
> Since these are only hints, we happily fake them for now
> to make applications not barf on ENOSYS.

Applied, thanks.

> Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> ---
>  linux-user/syscall.c |   21 +++++++++++++++++++++
>  1 files changed, 21 insertions(+), 0 deletions(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 489f632..f9aab47 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5572,6 +5572,27 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
>      case TARGET_NR_mincore:
>          goto unimplemented;
>  #endif
> +#ifdef TARGET_NR_arm_fadvise64_64
> +    case TARGET_NR_arm_fadvise64_64:
> +	{
> +		/*
> +		 * arm_fadvise64_64 looks like fadvise64_64 but
> +		 * with different argument order
> +		 */
> +		abi_long temp;
> +		temp = arg3;
> +		arg3 = arg4;
> +		arg4 = temp;
> +	}
> +#endif
> +#if defined(TARGET_NR_fadvise64_64) || defined(TARGET_NR_arm_fadvise64_64)
> +#ifdef TARGET_NR_fadvise64_64
> +    case TARGET_NR_fadvise64_64:
> +#endif
> +        /* This is a hint, so ignoring and returning success is ok.  */
> +	ret = get_errno(0);
> +	break;
> +#endif
>  #ifdef TARGET_NR_madvise
>      case TARGET_NR_madvise:
>          /* A straight passthrough may not be safe because qemu sometimes
> -- 
> 1.5.6.5.GIT
> 
> 
> 
> 

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net