From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Reset CPU on INIT IPI
Date: Thu, 2 Oct 2008 00:02:14 +0200 [thread overview]
Message-ID: <20081001220214.GH31270@volta.aurel32.net> (raw)
In-Reply-To: <20080925113153.GB7754@minantech.com>
On Thu, Sep 25, 2008 at 02:31:53PM +0300, Gleb Natapov wrote:
> INIT IPI should reset CPU. Also non boot CPU should be halted. It will
> be un-halted by SIPI.
Applied, thanks.
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
>
> diff --git a/hw/apic.c b/hw/apic.c
> index 64e75ad..1a44c3a 100644
> --- a/hw/apic.c
> +++ b/hw/apic.c
> @@ -458,6 +458,11 @@ static void apic_init_ipi(APICState *s)
> s->initial_count = 0;
> s->initial_count_load_time = 0;
> s->next_time = 0;
> +
> + cpu_reset(s->cpu_env);
> +
> + if (!(s->apicbase & MSR_IA32_APICBASE_BSP))
> + s->cpu_env->halted = 1;
> }
>
> /* send a SIPI message to the CPU to start it */
> --
> Gleb.
>
>
>
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
prev parent reply other threads:[~2008-10-01 22:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 11:31 [Qemu-devel] [PATCH] Reset CPU on INIT IPI Gleb Natapov
2008-10-01 22:02 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081001220214.GH31270@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).