* [Qemu-devel] [PATCH] Reset CPU on INIT IPI
@ 2008-09-25 11:31 Gleb Natapov
2008-10-01 22:02 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Gleb Natapov @ 2008-09-25 11:31 UTC (permalink / raw)
To: qemu-devel
INIT IPI should reset CPU. Also non boot CPU should be halted. It will
be un-halted by SIPI.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
diff --git a/hw/apic.c b/hw/apic.c
index 64e75ad..1a44c3a 100644
--- a/hw/apic.c
+++ b/hw/apic.c
@@ -458,6 +458,11 @@ static void apic_init_ipi(APICState *s)
s->initial_count = 0;
s->initial_count_load_time = 0;
s->next_time = 0;
+
+ cpu_reset(s->cpu_env);
+
+ if (!(s->apicbase & MSR_IA32_APICBASE_BSP))
+ s->cpu_env->halted = 1;
}
/* send a SIPI message to the CPU to start it */
--
Gleb.
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] Reset CPU on INIT IPI
2008-09-25 11:31 [Qemu-devel] [PATCH] Reset CPU on INIT IPI Gleb Natapov
@ 2008-10-01 22:02 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2008-10-01 22:02 UTC (permalink / raw)
To: qemu-devel
On Thu, Sep 25, 2008 at 02:31:53PM +0300, Gleb Natapov wrote:
> INIT IPI should reset CPU. Also non boot CPU should be halted. It will
> be un-halted by SIPI.
Applied, thanks.
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
>
> diff --git a/hw/apic.c b/hw/apic.c
> index 64e75ad..1a44c3a 100644
> --- a/hw/apic.c
> +++ b/hw/apic.c
> @@ -458,6 +458,11 @@ static void apic_init_ipi(APICState *s)
> s->initial_count = 0;
> s->initial_count_load_time = 0;
> s->next_time = 0;
> +
> + cpu_reset(s->cpu_env);
> +
> + if (!(s->apicbase & MSR_IA32_APICBASE_BSP))
> + s->cpu_env->halted = 1;
> }
>
> /* send a SIPI message to the CPU to start it */
> --
> Gleb.
>
>
>
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-01 22:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-25 11:31 [Qemu-devel] [PATCH] Reset CPU on INIT IPI Gleb Natapov
2008-10-01 22:02 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).