From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>, Jes Sorensen <jes@sgi.com>
Subject: Re: [Qemu-devel] [patch] Introduce per machine based max_cpu variable
Date: Thu, 2 Oct 2008 16:45:34 +0100 [thread overview]
Message-ID: <200810021645.35683.paul@codesourcery.com> (raw)
In-Reply-To: <48DBAC61.9090906@sgi.com>
> Here's an attempt of implementing a per-machine max_cpus variable.
> This means developers can limit smp support to match the actual board
> sizes. It also makes the static MAX_CPUS check in vl.c obsolete which
> I think is a good thing :-)
This looks reasonable, but is still not an ideal solution. It is an
improvement over what we currently have, so I'm not going to object to it
being applied.
The maximum number of CPUs may be a property of the CPU, not the board.
Especially in the embedded world it's becoming common to have multicore CPUs
connected to dumb single socket systems/boards.
IMHO max_cpus should be the actual number of cpus, not N-1 as has been
suggested elsewhere in this thread. It may be ok to accept max_cpus==0 as a
special case meaning max_cpus==1 to avoid having to change all the machine
descriptions. Probably less confusing to just make all the changes you
suggested though.
Paul
next prev parent reply other threads:[~2008-10-02 15:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-23 11:44 [Qemu-devel] [patch] move MAX_CPUS to cpu.h Jes Sorensen
2008-09-23 12:08 ` Paul Brook
2008-09-23 12:10 ` Jes Sorensen
2008-09-23 12:50 ` Paul Brook
2008-09-23 12:53 ` Jes Sorensen
2008-09-23 13:04 ` Paul Brook
2008-09-23 13:10 ` Jes Sorensen
2008-09-25 15:21 ` [Qemu-devel] [patch] Introduce per machine based max_cpu variable Jes Sorensen
2008-09-30 14:47 ` Anthony Liguori
2008-09-30 15:06 ` Jes Sorensen
2008-09-30 15:18 ` Anthony Liguori
2008-10-01 13:22 ` Jes Sorensen
2008-09-30 15:19 ` Jes Sorensen
2008-10-02 15:45 ` Paul Brook [this message]
2008-10-03 9:40 ` Jes Sorensen
2008-09-23 14:13 ` [Qemu-devel] [patch] move MAX_CPUS to cpu.h M. Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810021645.35683.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=aliguori@us.ibm.com \
--cc=jes@sgi.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).