From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Km51V-0003A6-43 for qemu-devel@nongnu.org; Sat, 04 Oct 2008 07:10:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Km51T-00039R-B6 for qemu-devel@nongnu.org; Sat, 04 Oct 2008 07:10:08 -0400 Received: from [199.232.76.173] (port=52516 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Km51T-00039O-8D for qemu-devel@nongnu.org; Sat, 04 Oct 2008 07:10:07 -0400 Received: from batfish.pepperfish.net ([87.237.62.180]:34986 helo=flounder.pepperfish.net) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Km51S-0008I9-TO for qemu-devel@nongnu.org; Sat, 04 Oct 2008 07:10:07 -0400 Received: from jennifer-internal.kyllikki.org ([10.112.102.2] helo=jennifer.kylikki.org) by flounder.pepperfish.net with esmtps (Exim 4.68 #1 (Debian)) id 1Km51P-00010O-Tf for ; Sat, 04 Oct 2008 12:10:03 +0100 Received: from derik.kyllikki.org ([192.168.7.20]) by jennifer.kylikki.org with esmtp (Exim 4.63) (envelope-from ) id 1Km51P-0000Ww-Bv for qemu-devel@nongnu.org; Sat, 04 Oct 2008 12:10:03 +0100 Received: from vince by derik.kyllikki.org with local (Exim 4.69) (envelope-from ) id 1Km51P-0001gg-1D for qemu-devel@nongnu.org; Sat, 04 Oct 2008 12:10:03 +0100 Date: Sat, 4 Oct 2008 12:10:02 +0100 From: Vincent Sanders Message-ID: <20081004111002.GA14712@kyllikki.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="M9NhX3UHpAaciwkO" Content-Disposition: inline Subject: [Qemu-devel] Small issue in the IDE emulation Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org --M9NhX3UHpAaciwkO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable While doing some other work I have come across a small issue with the DIAGNOSE command in the qemu IDE implementation. The status register value is dependant on the drive being a packet device or not. The simple patch (attached) fixes this. =3D=3D=3D modified file 'hw/ide.c' --- hw/ide.c 2008-10-01 01:43:16 +0000 +++ hw/ide.c 2008-10-04 10:56:58 +0000 @@ -2308,8 +2308,15 @@ break; case WIN_DIAGNOSE: ide_set_signature(s); - s->status =3D READY_STAT | SEEK_STAT; - s->error =3D 0x01; + if (s->is_cdrom) + s->status =3D 0; /* ATAPI spec (v6) section 9.10 defines p= acket + * devices to return a clear status register + * with READY_STAT *not* set. */ + else + s->status =3D READY_STAT | SEEK_STAT; + s->error =3D 0x01; /* Device 0 passed, Device 1 passed or not + * present.=20 + */ ide_set_irq(s); break; case WIN_SRST: --=20 Regards Vincent http://www.kyllikki.org/ --M9NhX3UHpAaciwkO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFI508KiUwwPOvjHvURAoT0AKD34M85zZ8UvtYzx3rDlHLFKd40zgCguisA l3Co7uOfrkagBtlJMZdqjEM= =YfI2 -----END PGP SIGNATURE----- --M9NhX3UHpAaciwkO--