From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Km5LQ-0002T0-Fh
	for qemu-devel@nongnu.org; Sat, 04 Oct 2008 07:30:44 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Km5LO-0002Sm-B0
	for qemu-devel@nongnu.org; Sat, 04 Oct 2008 07:30:43 -0400
Received: from [199.232.76.173] (port=59548 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Km5LO-0002Si-7X
	for qemu-devel@nongnu.org; Sat, 04 Oct 2008 07:30:42 -0400
Received: from solo.fdn.fr ([80.67.169.19]:51276)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <samuel.thibault@labri.fr>) id 1Km5LN-0007te-QL
	for qemu-devel@nongnu.org; Sat, 04 Oct 2008 07:30:42 -0400
Received: from implementation.famille.thibault.fr (reverse-89.fdn.fr
	[80.67.176.89]) (using TLSv1 with cipher AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by solo.fdn.fr (Postfix) with ESMTP id DFE8044E70
	for <qemu-devel@nongnu.org>; Sat,  4 Oct 2008 13:30:36 +0200 (CEST)
Received: from samy by implementation.famille.thibault.fr with local (Exim
	4.69) (envelope-from <samuel.thibault@labri.fr>) id 1Km5LK-0002Z7-0J
	for qemu-devel@nongnu.org; Sat, 04 Oct 2008 13:30:38 +0200
Date: Sat, 4 Oct 2008 13:30:37 +0200
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [Qemu-devel] Small issue in the IDE emulation
Message-ID: <20081004113037.GA4540@implementation.famille.thibault.fr>
References: <20081004111002.GA14712@kyllikki.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20081004111002.GA14712@kyllikki.org>
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Vincent Sanders, le Sat 04 Oct 2008 12:10:02 +0100, a =E9crit :
> While doing some other work I have come across a small issue with the
> DIAGNOSE command in the qemu IDE implementation. The status register
> value is dependant on the drive being a packet device or not. The
> simple patch (attached) fixes this.
>=20
> =3D=3D=3D modified file 'hw/ide.c'
> --- hw/ide.c	2008-10-01 01:43:16 +0000
> +++ hw/ide.c	2008-10-04 10:56:58 +0000
> @@ -2308,8 +2308,15 @@
>              break;
>          case WIN_DIAGNOSE:
>              ide_set_signature(s);
> -            s->status =3D READY_STAT | SEEK_STAT;
> -            s->error =3D 0x01;
> +            if (s->is_cdrom)
> +                s->status =3D 0; /* ATAPI spec (v6) section 9.10 defin=
es packet
> +                                * devices to return a clear status reg=
ister
> +                                * with READY_STAT *not* set. */

But shouldn't we at least set SEEK_STAT?

Samuel