qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thiemo Seufer <ths@networkno.de>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>, Jes Sorensen <jes@sgi.com>
Subject: Re: [Qemu-devel] [patch 1/2] machine struct - use C99 initializers
Date: Mon, 6 Oct 2008 17:30:33 +0200	[thread overview]
Message-ID: <20081006153033.GB23799@networkno.de> (raw)
In-Reply-To: <alpine.DEB.1.00.0810061701090.22125@pacific.mpi-cbg.de.mpi-cbg.de>

Johannes Schindelin wrote:
> Hi,
> 
> On Mon, 6 Oct 2008, Jes Sorensen wrote:
> 
> > This patch simply converts all the machine structs to use C99 style 
> > initializers. There is no actual code change in this.
> 
> Is it really such a good idea to do this?  I mean, the only real change 
> you make here is to break compilation on compilers that do not grok C99 
> (or do it badly).

AFAICS Qemu is still stuck with GCC3 or later. Are you aware of a GCC 3.x
version which is capable of building dyngen code but can't handle C99
initializers?


Thiemo

  parent reply	other threads:[~2008-10-06 15:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-06 13:09 [Qemu-devel] [patch 1/2] machine struct - use C99 initializers Jes Sorensen
2008-10-06 15:05 ` Johannes Schindelin
2008-10-06 15:03   ` Jes Sorensen
2008-10-06 15:26     ` Johannes Schindelin
2008-10-06 15:23       ` Anthony Liguori
2008-10-06 20:22     ` Ronan Keryell
2008-10-06 22:46     ` Andreas Färber
2008-10-06 23:07       ` Paul Brook
2008-10-06 23:38         ` M. Warner Losh
2008-10-07 13:50           ` Paul Brook
2008-10-07  7:13       ` Jes Sorensen
2008-10-26 15:17         ` Andreas Färber
2008-10-06 15:30   ` Thiemo Seufer [this message]
2008-10-07 20:34 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081006153033.GB23799@networkno.de \
    --to=ths@networkno.de \
    --cc=aliguori@us.ibm.com \
    --cc=jes@sgi.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).