From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KmsZD-00018S-Qd
	for qemu-devel@nongnu.org; Mon, 06 Oct 2008 12:04:15 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KmsZB-00017n-SY
	for qemu-devel@nongnu.org; Mon, 06 Oct 2008 12:04:15 -0400
Received: from [199.232.76.173] (port=57332 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KmsZB-00017h-KX
	for qemu-devel@nongnu.org; Mon, 06 Oct 2008 12:04:13 -0400
Received: from bart.se.axis.com ([195.60.68.10]:50859)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <edgar.iglesias@axis.com>) id 1KmsZB-0002XD-8U
	for qemu-devel@nongnu.org; Mon, 06 Oct 2008 12:04:13 -0400
Received: from bart.se.axis.com (bart.se.axis.com [127.0.0.1])
	by bart.se.axis.com (Postfix) with ESMTP id 2C4EF64127
	for <qemu-devel@nongnu.org>; Mon,  6 Oct 2008 18:04:11 +0200 (CEST)
Received: from axis.com (edgar.se.axis.com [10.93.151.1])
	by bart.se.axis.com (Postfix) with ESMTP id 15568640B3
	for <qemu-devel@nongnu.org>; Mon,  6 Oct 2008 18:04:11 +0200 (CEST)
Date: Mon, 6 Oct 2008 18:04:10 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@axis.com>
Subject: Re: [Qemu-devel] [PATCH] sparc: show size for unassigned accesses
Message-ID: <20081006160410.GE32110@edgar.se.axis.com>
References: <48E430EB.5020202@earthlink.net>
	<f43fc5580810021102m44e41889g5f42c9b79bd67698@mail.gmail.com>
	<48E9A000.7040808@earthlink.net>
	<f43fc5580810060856v4859fb00y94799056cf72e143@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f43fc5580810060856v4859fb00y94799056cf72e143@mail.gmail.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

On Mon, Oct 06, 2008 at 06:56:14PM +0300, Blue Swirl wrote:
> On 10/6/08, Robert Reif <reif@earthlink.net> wrote:
> > Blue Swirl wrote:
> >
> > > On 10/2/08, Robert Reif <reif@earthlink.net> wrote:
> > >
> > >
> > > >  #ifdef TARGET_SPARC
> > > >  +    do_unassigned_access(addr, 0, 0, 0, 1);
> > > >  +#elif defined(TARGET_CRIS)
> > > >     do_unassigned_access(addr, 0, 0, 0);
> > > >  +#endif
> > > >  +    return 0;
> > > >
> > > >
> > >
> > > I think it would be cleaner solution to convert also CRIS and MIPS
> > > versions to take the size argument.
> 
> Is this patch OK for CRIS and MIPS too? The extra parameter should not hurt.

It doesn't hurt for CRIS.

Thanks