From: Thiemo Seufer <ths@networkno.de>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] sparc: show size for unassigned accesses
Date: Mon, 6 Oct 2008 18:56:22 +0200 [thread overview]
Message-ID: <20081006165622.GA14187@networkno.de> (raw)
In-Reply-To: <f43fc5580810060856v4859fb00y94799056cf72e143@mail.gmail.com>
Blue Swirl wrote:
> On 10/6/08, Robert Reif <reif@earthlink.net> wrote:
> > Blue Swirl wrote:
> >
> > > On 10/2/08, Robert Reif <reif@earthlink.net> wrote:
> > >
> > >
> > > > #ifdef TARGET_SPARC
> > > > + do_unassigned_access(addr, 0, 0, 0, 1);
> > > > +#elif defined(TARGET_CRIS)
> > > > do_unassigned_access(addr, 0, 0, 0);
> > > > +#endif
> > > > + return 0;
> > > >
> > > >
> > >
> > > I think it would be cleaner solution to convert also CRIS and MIPS
> > > versions to take the size argument.
>
> Is this patch OK for CRIS and MIPS too? The extra parameter should not hurt.
Acked-by: Thiemo Seufer <ths@networkno.de>
next prev parent reply other threads:[~2008-10-06 16:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 2:24 [Qemu-devel] [PATCH] sparc: show size for unassigned accesses Robert Reif
2008-10-02 18:02 ` Blue Swirl
2008-10-06 5:20 ` Robert Reif
2008-10-06 15:56 ` Blue Swirl
2008-10-06 16:04 ` Edgar E. Iglesias
2008-10-06 16:56 ` Thiemo Seufer [this message]
2008-10-06 18:47 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081006165622.GA14187@networkno.de \
--to=ths@networkno.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).