From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kmu9q-0002O0-Ru for qemu-devel@nongnu.org; Mon, 06 Oct 2008 13:46:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kmu9p-0002NT-8P for qemu-devel@nongnu.org; Mon, 06 Oct 2008 13:46:10 -0400 Received: from [199.232.76.173] (port=51258 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kmu9p-0002NO-4F for qemu-devel@nongnu.org; Mon, 06 Oct 2008 13:46:09 -0400 Received: from mx1.redhat.com ([66.187.233.31]:51640) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kmu9o-00081B-8e for qemu-devel@nongnu.org; Mon, 06 Oct 2008 13:46:08 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m96Hk7CM003979 for ; Mon, 6 Oct 2008 13:46:07 -0400 Received: from file.fab.redhat.com (file.fab.redhat.com [10.33.63.6]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m96Hk6VT024592 for ; Mon, 6 Oct 2008 13:46:07 -0400 Received: from file.fab.redhat.com (localhost.localdomain [127.0.0.1]) by file.fab.redhat.com (8.13.1/8.13.1) with ESMTP id m96Hk62b004820 for ; Mon, 6 Oct 2008 18:46:06 +0100 Received: (from berrange@localhost) by file.fab.redhat.com (8.13.1/8.13.1/Submit) id m96Hk6A4004816 for qemu-devel@nongnu.org; Mon, 6 Oct 2008 18:46:06 +0100 Date: Mon, 6 Oct 2008 18:46:06 +0100 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [Patch 3/4] [RFC] Zero Cluster Dedup, Offline dedup, qemu-img extentions Message-ID: <20081006174606.GW20979@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Mon, Oct 06, 2008 at 10:31:39AM -0700, Shahar Frank wrote: > MDSUM Extension for the map verb > > Signed-off-by: Shahar Frank > > @@ -496,6 +501,7 @@ elif [ "$bsd" = "yes" ]; then > else > # Some Linux architectures (e.g. s390) don't imply -lpthread > automatically. > AIOLIBS="-lrt -lpthread" > + MD5SUMLIBS="-lssl" > fi > > # Check for gcc4, error if pre-gcc4 > @@ -920,6 +926,20 @@ EOF We're already linking to GCrypt/GNUTLS for SSL stuff in the VNC server, and one crypto/SSL library per application really ought to be enough. GCrypt has APIs for doing md5 hashing (and pretty much every other hashing algo you can think of). Furthermore, OpenSSL's licensing terms are commonly considered to be incompatible with the GPL, unless you add an explicit exception allowing linking to OpenSSL. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|