From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KoI6X-0007U8-5A
	for qemu-devel@nongnu.org; Fri, 10 Oct 2008 09:32:29 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KoI6V-0007RZ-DE
	for qemu-devel@nongnu.org; Fri, 10 Oct 2008 09:32:28 -0400
Received: from [199.232.76.173] (port=48128 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KoI6V-0007RB-4z
	for qemu-devel@nongnu.org; Fri, 10 Oct 2008 09:32:27 -0400
Received: from mail.codesourcery.com ([65.74.133.4]:44897)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1KoI6U-0007CY-A5
	for qemu-devel@nongnu.org; Fri, 10 Oct 2008 09:32:26 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [patch 2/2] Add Flash support to the Versatile PB
	platform
Date: Fri, 10 Oct 2008 14:32:22 +0100
References: <20081010083602.692750032@free-electrons.com>
	<200810101402.18569.paul@codesourcery.com>
	<20081010151716.1407f4ba@surf>
In-Reply-To: <20081010151716.1407f4ba@surf>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200810101432.23151.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: qemu-devel@nongnu.org, michael@free-electrons.com

On Friday 10 October 2008, Thomas Petazzoni wrote:
> Le Fri, 10 Oct 2008 14:02:17 +0100,
>
> Paul Brook <paul@codesourcery.com> a =C3=A9crit :
> > > +    if (! hasflash) {
> > > +      versatile_binfo.ram_size =3D ram_size;
> >
> > This should be dependent on the presence of the -kernel option, not
> > the absence of flash.
>
> Yes, makes sense. How should it behave when neither -kernel nor -pflash
> are present ? Just display an error message and exit ?

Yes.

Paul