From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KoHrw-0001R2-D8
	for qemu-devel@nongnu.org; Fri, 10 Oct 2008 09:17:24 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KoHru-0001OI-QG
	for qemu-devel@nongnu.org; Fri, 10 Oct 2008 09:17:23 -0400
Received: from [199.232.76.173] (port=35620 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KoHru-0001OB-Ka
	for qemu-devel@nongnu.org; Fri, 10 Oct 2008 09:17:22 -0400
Received: from mail.free-electrons.com ([88.191.76.200]:35874)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <thomas.petazzoni@free-electrons.com>)
	id 1KoHru-00043z-9m
	for qemu-devel@nongnu.org; Fri, 10 Oct 2008 09:17:22 -0400
Date: Fri, 10 Oct 2008 15:17:16 +0200
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Subject: Re: [Qemu-devel] [patch 2/2] Add Flash support to the Versatile PB
	platform
Message-ID: <20081010151716.1407f4ba@surf>
In-Reply-To: <200810101402.18569.paul@codesourcery.com>
References: <20081010083602.692750032@free-electrons.com>
	<20081010084123.763042429@free-electrons.com>
	<200810101402.18569.paul@codesourcery.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org, michael@free-electrons.com

Le Fri, 10 Oct 2008 14:02:17 +0100,
Paul Brook <paul@codesourcery.com> a =C3=A9crit :

> > +    if (! hasflash) {
> > +      versatile_binfo.ram_size =3D ram_size;
>=20
> This should be dependent on the presence of the -kernel option, not
> the absence of flash.

Yes, makes sense. How should it behave when neither -kernel nor -pflash
are present ? Just display an error message and exit ?

Thanks a lot for your feedback,

Thomas
--=20
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com