From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [5465] hw/apic.c: use __builtin funtions instead of assembly code
Date: Sun, 12 Oct 2008 20:17:08 +0100 [thread overview]
Message-ID: <200810122017.09078.paul@codesourcery.com> (raw)
In-Reply-To: <E1KopCv-0001X3-Qp@cvs.savannah.gnu.org>
On Sunday 12 October 2008, Aurelien Jarno wrote:
> static int fls_bit(uint32_t value)
> {
> +#if defined(__GNUC__)
> + return 31 - __builtin_clz(value);
This should be using clz32, not duplicating this code.
Paul
prev parent reply other threads:[~2008-10-12 19:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-12 0:53 [Qemu-devel] [5465] hw/apic.c: use __builtin funtions instead of assembly code Aurelien Jarno
2008-10-12 10:21 ` [Qemu-devel] " Jan Kiszka
2008-10-12 11:44 ` Aurelien Jarno
2008-10-12 19:17 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810122017.09078.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).