From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org, dsilvers@simtec.co.uk
Subject: Re: [Qemu-devel] [PATCH] ARM CP14 trivial support
Date: Mon, 13 Oct 2008 13:39:23 +0100 [thread overview]
Message-ID: <200810131339.24217.paul@codesourcery.com> (raw)
In-Reply-To: <1223894552.30000.30.camel@petitemort>
On Monday 13 October 2008, Daniel Silverstone wrote:
> Hi,
>
> Continuing the patch series aiming at supporting Simtec's development
> boards and other Samsung SoC based systems, attached is a patch which
> provides trivial coprocessor 14 support.
I dislike code that blindly ignores everything. Functions should be explicitly
not implemented (with comments saying exactly what we're not implementing),
or fail loudly when used.
The cp14 interface is also used for other debug monitor hardware (breakpoints,
watchpoints, etc.) and possibly Jazelle DBX. Ignoring those commands is bad.
IIRC cp14 interfaces are device specific (at least before ARMv6), so you need
to figure out which cores your hacks apply to. There are definitely several
different DDC interfaces.
Paul
next prev parent reply other threads:[~2008-10-13 12:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 10:42 [Qemu-devel] [PATCH] ARM CP14 trivial support Daniel Silverstone
2008-10-13 12:39 ` Paul Brook [this message]
2008-10-13 12:50 ` andrzej zaborowski
2008-10-13 13:20 ` Paul Brook
2008-10-13 14:30 ` andrzej zaborowski
2008-10-13 14:36 ` Paul Brook
2008-10-13 14:57 ` andrzej zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810131339.24217.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=dsilvers@simtec.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).