From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org, dsilvers@simtec.co.uk
Subject: Re: [Qemu-devel] [PATCH] Davicom DM9000 emulation
Date: Mon, 13 Oct 2008 13:47:21 +0100 [thread overview]
Message-ID: <200810131347.21761.paul@codesourcery.com> (raw)
In-Reply-To: <1223892743.30000.25.camel@petitemort>
On Monday 13 October 2008, Daniel Silverstone wrote:
> Hi,
>
> Attached is a patch which provides Davicom DM9000E emulation support
> including the ability to compile in a pcap-style network trace of the
> device.
Network dumping does not belong in device specific code. It should be a
separate device that can be attached to the virtual network.
> +#define DM9000_DBF(X...) if(0) fprintf(stderr, X)
This is wrong. Use do {} while(0)
> +/* hw/dm9000.h
A new header file for one init function is excessive. dm9000_init should go in
the same place as smc91c111_init.
> +OBJS += dm9000.o
Likewise, this should be the same as smc91c111.o.
Paul
next prev parent reply other threads:[~2008-10-13 12:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 10:12 [Qemu-devel] [PATCH] Davicom DM9000 emulation Daniel Silverstone
2008-10-13 12:47 ` Paul Brook [this message]
2008-10-13 14:01 ` Daniel Silverstone
2008-10-13 14:20 ` Daniel Silverstone
2008-10-13 14:34 ` Paul Brook
2008-10-13 14:37 ` Daniel Silverstone
2008-10-13 14:53 ` Paul Brook
2008-10-13 15:13 ` Daniel Silverstone
2008-10-21 8:43 ` Daniel Silverstone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810131347.21761.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=dsilvers@simtec.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).