From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KpMpg-0006qa-Sw for qemu-devel@nongnu.org; Mon, 13 Oct 2008 08:47:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KpMpf-0006qF-H8 for qemu-devel@nongnu.org; Mon, 13 Oct 2008 08:47:32 -0400 Received: from [199.232.76.173] (port=59134 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KpMpf-0006qC-CO for qemu-devel@nongnu.org; Mon, 13 Oct 2008 08:47:31 -0400 Received: from mail.codesourcery.com ([65.74.133.4]:35937) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KpMpe-0004CG-Rv for qemu-devel@nongnu.org; Mon, 13 Oct 2008 08:47:31 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] Davicom DM9000 emulation Date: Mon, 13 Oct 2008 13:47:21 +0100 References: <1223892743.30000.25.camel@petitemort> In-Reply-To: <1223892743.30000.25.camel@petitemort> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200810131347.21761.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, dsilvers@simtec.co.uk On Monday 13 October 2008, Daniel Silverstone wrote: > Hi, > > Attached is a patch which provides Davicom DM9000E emulation support > including the ability to compile in a pcap-style network trace of the > device. Network dumping does not belong in device specific code. It should be a separate device that can be attached to the virtual network. > +#define DM9000_DBF(X...) if(0) fprintf(stderr, X) This is wrong. Use do {} while(0) > +/* hw/dm9000.h A new header file for one init function is excessive. dm9000_init should go in the same place as smc91c111_init. > +OBJS += dm9000.o Likewise, this should be the same as smc91c111.o. Paul