From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] 2/5: open() can also return EPERM for O_RDWR on a readonly device
Date: Mon, 13 Oct 2008 23:08:44 +0200 [thread overview]
Message-ID: <20081013210844.GC18008@volta.aurel32.net> (raw)
In-Reply-To: <20081001183609.GA70515@saturn.kn-bremen.de>
Applied, thanks.
On Wed, Oct 01, 2008 at 08:36:09PM +0200, Juergen Lock wrote:
> ..at least on FreeBSD. (I think the case where this happened was a cdrom.)
>
> Index: qemu/block.c
> @@ -381,7 +381,7 @@
> else
> open_flags = flags & ~(BDRV_O_FILE | BDRV_O_SNAPSHOT);
> ret = drv->bdrv_open(bs, filename, open_flags);
> - if (ret == -EACCES && !(flags & BDRV_O_FILE)) {
> + if ((ret == -EACCES || ret == -EPERM) && !(flags & BDRV_O_FILE)) {
> ret = drv->bdrv_open(bs, filename, BDRV_O_RDONLY);
> bs->read_only = 1;
> }
>
> Signed-off-by: Juergen Lock <nox@jelal.kn-bremen.de>
>
>
>
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
prev parent reply other threads:[~2008-10-13 21:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 18:36 [Qemu-devel] [PATCH] 2/5: open() can also return EPERM for O_RDWR on a readonly device Juergen Lock
2008-10-13 21:08 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081013210844.GC18008@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).