From: Aurelien Jarno <aurelien@aurel32.net>
To: "Hervé Poussineau" <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] MIPS: call XREFILL handler when required
Date: Tue, 14 Oct 2008 10:53:07 +0200 [thread overview]
Message-ID: <20081014085307.GA23008@hall.aurel32.net> (raw)
In-Reply-To: <48EA7A3B.7010607@reactos.org>
On Mon, Oct 06, 2008 at 10:51:07PM +0200, Hervé Poussineau wrote:
> Hi,
>
> In TLB Load and TLB Store exceptions, we should look at the Status
> register to know in which mode we are.
> Existing code checks upper bits of the address, which is totally wrong.
>
You are wrong. The current code is correct.
If you look at the "MIPS64 Privileged Resource Architecture document",
table "4.5 Access Control as a Function of Address and Operating Mode"
(page 17 in my edition), you will see that the refill vector actually
depends on the address and not on the current mode.
That's why your patch doesn't allow a 64-bit linux kernel to boot.
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
prev parent reply other threads:[~2008-10-14 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 20:51 [Qemu-devel] [PATCH] MIPS: call XREFILL handler when required Hervé Poussineau
2008-10-13 21:15 ` Aurelien Jarno
2008-10-14 8:53 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014085307.GA23008@hall.aurel32.net \
--to=aurelien@aurel32.net \
--cc=hpoussin@reactos.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).