From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KpfeW-00038S-CB
	for qemu-devel@nongnu.org; Tue, 14 Oct 2008 04:53:16 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KpfeT-00037l-Bs
	for qemu-devel@nongnu.org; Tue, 14 Oct 2008 04:53:13 -0400
Received: from [199.232.76.173] (port=41899 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KpfeP-00037T-RW
	for qemu-devel@nongnu.org; Tue, 14 Oct 2008 04:53:10 -0400
Received: from hall.aurel32.net ([88.191.82.174]:36374)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1KpfeP-00021X-Du
	for qemu-devel@nongnu.org; Tue, 14 Oct 2008 04:53:09 -0400
Date: Tue, 14 Oct 2008 10:53:07 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] MIPS: call XREFILL handler when required
Message-ID: <20081014085307.GA23008@hall.aurel32.net>
References: <48EA7A3B.7010607@reactos.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <48EA7A3B.7010607@reactos.org>
Sender: Aurelien Jarno <aurelien@aurel32.net>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-15?Q?Herv=E9?= Poussineau <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org

On Mon, Oct 06, 2008 at 10:51:07PM +0200, Hervé Poussineau wrote:
> Hi,
> 
> In TLB Load and TLB Store exceptions, we should look at the Status 
> register to know in which mode we are.
> Existing code checks upper bits of the address, which is totally wrong.
> 

You are wrong. The current code is correct.

If you look at the "MIPS64 Privileged Resource Architecture document",
table "4.5 Access Control as a Function of Address and Operating Mode"
(page 17 in my edition), you will see that the refill vector actually
depends on the address and not on the current mode.

That's why your patch doesn't allow a 64-bit linux kernel to boot.

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net