From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KpmN5-00016f-Ir
	for qemu-devel@nongnu.org; Tue, 14 Oct 2008 12:03:43 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KpmN3-00014m-Tf
	for qemu-devel@nongnu.org; Tue, 14 Oct 2008 12:03:43 -0400
Received: from [199.232.76.173] (port=47030 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KpmN3-00014Z-OB
	for qemu-devel@nongnu.org; Tue, 14 Oct 2008 12:03:41 -0400
Received: from mx2.redhat.com ([66.187.237.31]:51791)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@redhat.com>) id 1KpmN3-0008L2-58
	for qemu-devel@nongnu.org; Tue, 14 Oct 2008 12:03:41 -0400
Date: Tue, 14 Oct 2008 14:04:52 -0200
From: Glauber Costa <glommer@redhat.com>
Message-ID: <20081014160452.GC17842@poweredge.glommer>
References: <1223945508-22241-1-git-send-email-glommer@redhat.com>
	<1223945508-22241-5-git-send-email-glommer@redhat.com>
	<48F4C224.2010606@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <48F4C224.2010606@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 4/7] give noaccel a name
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: aliguori@us.ibm.com, jan.kiszka@siemens.com, jes@sgi.com, qemu-devel@nongnu.org, avi@qumranet.com, dmitry.baryshkov@siemens.com

On Tue, Oct 14, 2008 at 06:00:36PM +0200, Avi Kivity wrote:
> Glauber Costa wrote:
> > otherwise, string comparisons to check for the current accelerator
> > may break.
> >
> > Signed-off-by: Glauber Costa <glommer@redhat.com>
> > ---
> >  accel.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/accel.c b/accel.c
> > index f9618b2..bf3cb73 100644
> > --- a/accel.c
> > +++ b/accel.c
> > @@ -21,7 +21,7 @@ CPUState *noaccel_get_env(void)
> >  
> >  /* Accelerator wrapper for the no-accel (raw qemu) case */
> >  QEMUAccel noaccel = {
> > -    .name = NULL,
> > +    .name = "noaccel",
> >      .cpu_interrupt = accel_nop,
> >      .init_env = accel_nop,
> >      .get_env = noaccel_get_env,
> >   
> 
> Maybe "none" or "tcg" or "emulation"?
I think none is okay.

> 
> -- 
> Do not meddle in the internals of kernels, for they are subtle and quick to panic.
>