From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Nathan Froyd <froydnj@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH][ppc] convert SPE logical instructions to TCG
Date: Wed, 15 Oct 2008 10:32:27 +0100 [thread overview]
Message-ID: <200810151032.28296.paul@codesourcery.com> (raw)
In-Reply-To: <20081015020915.GM18389@codesourcery.com>
On Wednesday 15 October 2008 03:09:16 Nathan Froyd wrote:
> + TCGv t0 = tcg_temp_local_new(TCG_TYPE_I64);
> + TCGv t1 = tcg_temp_local_new(TCG_TYPE_I64);
These should be tcg_temp_new.
Local variables (tcg_temp_local_new) introduce a lot of additional overhead,
should only be used when absolutely necessary. A local variable is required
if the value is required to live over multiple basic blocks. i.e. accross a
branch op or a dyngen op. In the latter case it's probably best to eliminate
the dyngen op.
Paul
next prev parent reply other threads:[~2008-10-15 9:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 17:19 [Qemu-devel] [PATCH][ppc] convert SPE logical instructions to TCG Nathan Froyd
[not found] ` <CC7516B4-D44E-472F-BADE-D30481322C38@hotmail.com>
2008-10-14 17:33 ` C.W. Betts
2008-10-14 19:16 ` Aurelien Jarno
2008-10-15 2:09 ` Nathan Froyd
2008-10-15 9:32 ` Paul Brook [this message]
2008-10-15 17:00 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810151032.28296.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=froydnj@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).