[Qemu-devel] [PATCH] Add a missing return in syscall.c

[Qemu-devel] [PATCH] Add a missing return in syscall.c

[Laurent Desnogues]

[-- Attachment #1: Type: text/plain, Size: 85 bytes --]

Hello,

svn commit 5483 lacks a return in abi_long host_to_target_msginfo.


Laurent

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: syscall-return.patch --]
[-- Type: text/x-patch; name=syscall-return.patch, Size: 472 bytes --]

Index: linux-user/syscall.c
===================================================================
--- linux-user/syscall.c	(revision 5518)
+++ linux-user/syscall.c	(working copy)
@@ -1934,6 +1934,7 @@
     __put_user(host_msginfo->msgtql, &target_msginfo->msgtql);
     __put_user(host_msginfo->msgseg, &target_msginfo->msgseg);
     unlock_user_struct(target_msginfo, target_addr, 1);
+    return 0;
 }
 
 static inline abi_long do_msgctl(int msgid, int cmd, abi_long ptr)

Re: [Qemu-devel] [PATCH] Add a missing return in syscall.c

[Kirill A. Shutemov]

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

On Thu, Oct 23, 2008 at 12:33:30PM +0200, Laurent Desnogues wrote:
> Hello,
> 
> svn commit 5483 lacks a return in abi_long host_to_target_msginfo.
> 
> 
> Laurent

> Index: linux-user/syscall.c
> ===================================================================
> --- linux-user/syscall.c	(revision 5518)
> +++ linux-user/syscall.c	(working copy)
> @@ -1934,6 +1934,7 @@
>      __put_user(host_msginfo->msgtql, &target_msginfo->msgtql);
>      __put_user(host_msginfo->msgseg, &target_msginfo->msgseg);
>      unlock_user_struct(target_msginfo, target_addr, 1);
> +    return 0;
>  }
>  
>  static inline abi_long do_msgctl(int msgid, int cmd, abi_long ptr)

Ack.

Thanks.

-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.com/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]