* [Qemu-devel] [PATCH] fix bad memcpy length
@ 2008-10-23 21:47 Bruce Rogers
2008-10-23 22:00 ` Erik de Castro Lopo
0 siblings, 1 reply; 2+ messages in thread
From: Bruce Rogers @ 2008-10-23 21:47 UTC (permalink / raw)
To: qemu-devel
--- a/qemu/trunk/hw/bt-sdp.c
+++ b/qemu/trunk/hw/bt-sdp.c
@@ -254,7 +254,7 @@
/* Perform the search */
if (len < 7)
return -SDP_INVALID_SYNTAX;
- memcpy(&handle, req, 6);
+ memcpy(&handle, req, 4);
req += 4;
len -= 4;
Signed-off-by: <brogers@novell.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] fix bad memcpy length
2008-10-23 21:47 [Qemu-devel] [PATCH] fix bad memcpy length Bruce Rogers
@ 2008-10-23 22:00 ` Erik de Castro Lopo
0 siblings, 0 replies; 2+ messages in thread
From: Erik de Castro Lopo @ 2008-10-23 22:00 UTC (permalink / raw)
To: qemu-devel; +Cc: Bruce Rogers
Bruce Rogers wrote:
> --- a/qemu/trunk/hw/bt-sdp.c
> +++ b/qemu/trunk/hw/bt-sdp.c
> @@ -254,7 +254,7 @@
> /* Perform the search */
> if (len < 7)
> return -SDP_INVALID_SYNTAX;
> - memcpy(&handle, req, 6);
> + memcpy(&handle, req, 4);
Changing one magic number to another doesn't make much sense.
Why not this instead:
memcpy(&handle, req, sizeof (handle));
Erik
--
-----------------------------------------------------------------
Erik de Castro Lopo
-----------------------------------------------------------------
"life is too long to know C++ well" -- Erik Naggum
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-23 22:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-23 21:47 [Qemu-devel] [PATCH] fix bad memcpy length Bruce Rogers
2008-10-23 22:00 ` Erik de Castro Lopo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).