[Qemu-devel] [PATCH, RFC] Update disassembler files from latest binutils

[Qemu-devel] [PATCH, RFC] Update disassembler files from latest binutils

[Blue Swirl]

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

Hi,

The disassembler files should be updated to get newer instructions
supported. This is currently not easy because the *-dis.c files are
concatenated using several files from binutils. There are some Qemu
specific changes.

The first patch introduces a new directory "dis", moves sparc-dis.c
there, and splits it to three files as used in binutils: sparc-dis.c,
sparc-opc.c and sparc.h.

The second patch updates the files from binutils 2.18. The real
changes from 2002 binutils to current are not that large, but there is
some code movement and I changed tabs to spaces at one point. The
license changes from GPL v2 to v3.

I can introduce more staging patches if necessary. Comments?

[-- Attachment #2: split_dis.diff.bz2 --]
[-- Type: application/x-bzip2, Size: 34813 bytes --]

[-- Attachment #3: update_dis.diff.bz2 --]
[-- Type: application/x-bzip2, Size: 32357 bytes --]

Re: [Qemu-devel] [PATCH, RFC] Update disassembler files from latest binutils

[Kirill A. Shutemov]

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

On Fri, Oct 24, 2008 at 10:12:07PM +0300, Blue Swirl wrote:
> The second patch updates the files from binutils 2.18.

Why not 2.19? It is almost released.

-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.com/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [Qemu-devel] [PATCH, RFC] Update disassembler files from latest binutils

[Blue Swirl]

On 10/24/08, Kirill A. Shutemov <kirill@shutemov.name> wrote:
> On Fri, Oct 24, 2008 at 10:12:07PM +0300, Blue Swirl wrote:
>  > The second patch updates the files from binutils 2.18.
>
>
> Why not 2.19? It is almost released.

That's of course possible too. I haven't followed binutils development at all.

Re: [Qemu-devel] [PATCH, RFC] Update disassembler files from latest binutils

[Andreas Färber]

Am 24.10.2008 um 21:12 schrieb Blue Swirl:

> The second patch updates the files from binutils 2.18. The real
> changes from 2002 binutils to current are not that large, but there is
> some code movement and I changed tabs to spaces at one point. The
> license changes from GPL v2 to v3.

In January there were some complaints about GPLv3 (wasn't that for  
disassembler files?), try searching for "teenage mutant legal  
turtles". ;-)

It was reverted to using "GPLv2 or later" at the time.

Andreas

Re: [Qemu-devel] [PATCH, RFC] Update disassembler files from latest binutils

[Blue Swirl]

On 10/24/08, Andreas Färber <andreas.faerber@web.de> wrote:
>
>  Am 24.10.2008 um 21:12 schrieb Blue Swirl:
>
>
> > The second patch updates the files from binutils 2.18. The real
> > changes from 2002 binutils to current are not that large, but there is
> > some code movement and I changed tabs to spaces at one point. The
> > license changes from GPL v2 to v3.
> >
>
>  In January there were some complaints about GPLv3 (wasn't that for
> disassembler files?), try searching for "teenage mutant legal turtles". ;-)
>
>  It was reverted to using "GPLv2 or later" at the time.

But there are a lot of files with GPL v3 now:

bt-host.c: * (at your option) version 3 of the License.
bt-vhci.c: * (at your option) version 3 of the License.
hw/blizzard.c: * (at your option) version 3 of the License.
hw/blizzard_template.h: * (at your option) version 3 of the License.
hw/bt-hci-csr.c: * (at your option) version 3 of the License.
hw/bt-hid.c: * (at your option) version 3 of the License.
hw/bt.c: * (at your option) version 3 of the License.
hw/cbus.c: * (at your option) version 3 of the License.
hw/lm832x.c: * (at your option) version 3 of the License.
hw/nseries.c: * (at your option) version 3 of the License.
hw/omap.h: * (at your option) version 3 of the License.
hw/omap1.c: * (at your option) version 3 of the License.
hw/omap2.c: * (at your option) version 3 of the License.
hw/omap_dss.c: * (at your option) version 3 of the License.
hw/omap_mmc.c: * (at your option) version 3 of the License.
hw/onenand.c: * (at your option) version 3 of the License.
hw/palm.c: * (at your option) version 3 of the License.
hw/soc_dma.c: * (at your option) version 3 of the License.
hw/soc_dma.h: * (at your option) version 3 of the License.
hw/tmp105.c: * (at your option) version 3 of the License.
hw/tsc2005.c: * (at your option) version 3 of the License.
hw/tsc210x.c: * (at your option) version 3 of the License.
hw/tusb6010.c: * (at your option) version 3 of the License.
hw/twl92230.c: * (at your option) version 3 of the License.
hw/usb-bt.c: * (at your option) version 3 of the License.
hw/usb-musb.c: * (at your option) version 3 of the License.
hw/zaurus.c: * (at your option) version 3 of the License.

Re: [Qemu-devel] [PATCH, RFC] Update disassembler files from latest binutils

[Aurelien Jarno]

On Fri, Oct 24, 2008 at 10:59:16PM +0300, Blue Swirl wrote:
> On 10/24/08, Andreas Färber <andreas.faerber@web.de> wrote:
> >
> >  Am 24.10.2008 um 21:12 schrieb Blue Swirl:
> >
> >
> > > The second patch updates the files from binutils 2.18. The real
> > > changes from 2002 binutils to current are not that large, but there is
> > > some code movement and I changed tabs to spaces at one point. The
> > > license changes from GPL v2 to v3.
> > >
> >
> >  In January there were some complaints about GPLv3 (wasn't that for
> > disassembler files?), try searching for "teenage mutant legal turtles". ;-)
> >
> >  It was reverted to using "GPLv2 or later" at the time.
> 
> But there are a lot of files with GPL v3 now:

The fact that we already have GPL v3 file is not relevant. GPL v2 only
is not compatible with GPL v3. Either all the GPL v2 only file have to
be relicensed, or the GPL v3 only files have to be relicensed or 
removed.

> bt-host.c: * (at your option) version 3 of the License.
> bt-vhci.c: * (at your option) version 3 of the License.
> hw/blizzard.c: * (at your option) version 3 of the License.
> hw/blizzard_template.h: * (at your option) version 3 of the License.
> hw/bt-hci-csr.c: * (at your option) version 3 of the License.
> hw/bt-hid.c: * (at your option) version 3 of the License.
> hw/bt.c: * (at your option) version 3 of the License.
> hw/cbus.c: * (at your option) version 3 of the License.
> hw/lm832x.c: * (at your option) version 3 of the License.
> hw/nseries.c: * (at your option) version 3 of the License.
> hw/omap.h: * (at your option) version 3 of the License.
> hw/omap1.c: * (at your option) version 3 of the License.
> hw/omap2.c: * (at your option) version 3 of the License.
> hw/omap_dss.c: * (at your option) version 3 of the License.
> hw/omap_mmc.c: * (at your option) version 3 of the License.
> hw/onenand.c: * (at your option) version 3 of the License.
> hw/palm.c: * (at your option) version 3 of the License.
> hw/soc_dma.c: * (at your option) version 3 of the License.
> hw/soc_dma.h: * (at your option) version 3 of the License.
> hw/tmp105.c: * (at your option) version 3 of the License.
> hw/tsc2005.c: * (at your option) version 3 of the License.
> hw/tsc210x.c: * (at your option) version 3 of the License.
> hw/tusb6010.c: * (at your option) version 3 of the License.
> hw/twl92230.c: * (at your option) version 3 of the License.
> hw/usb-bt.c: * (at your option) version 3 of the License.
> hw/usb-musb.c: * (at your option) version 3 of the License.
> hw/zaurus.c: * (at your option) version 3 of the License.

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

Re: [Qemu-devel] [PATCH, RFC] Update disassembler files from latest binutils

[Stefan Weil]

Blue Swirl schrieb:
> But there are a lot of files with GPL v3 now:
>
> bt-host.c: * (at your option) version 3 of the License.
> bt-vhci.c: * (at your option) version 3 of the License.
> hw/blizzard.c: * (at your option) version 3 of the License.
> hw/blizzard_template.h: * (at your option) version 3 of the License.
> hw/bt-hci-csr.c: * (at your option) version 3 of the License.
> hw/bt-hid.c: * (at your option) version 3 of the License.
> hw/bt.c: * (at your option) version 3 of the License.
> hw/cbus.c: * (at your option) version 3 of the License.
> hw/lm832x.c: * (at your option) version 3 of the License.
> hw/nseries.c: * (at your option) version 3 of the License.
> hw/omap.h: * (at your option) version 3 of the License.
> hw/omap1.c: * (at your option) version 3 of the License.
> hw/omap2.c: * (at your option) version 3 of the License.
> hw/omap_dss.c: * (at your option) version 3 of the License.
> hw/omap_mmc.c: * (at your option) version 3 of the License.
> hw/onenand.c: * (at your option) version 3 of the License.
> hw/palm.c: * (at your option) version 3 of the License.
> hw/soc_dma.c: * (at your option) version 3 of the License.
> hw/soc_dma.h: * (at your option) version 3 of the License.
> hw/tmp105.c: * (at your option) version 3 of the License.
> hw/tsc2005.c: * (at your option) version 3 of the License.
> hw/tsc210x.c: * (at your option) version 3 of the License.
> hw/tusb6010.c: * (at your option) version 3 of the License.
> hw/twl92230.c: * (at your option) version 3 of the License.
> hw/usb-bt.c: * (at your option) version 3 of the License.
> hw/usb-musb.c: * (at your option) version 3 of the License.
> hw/zaurus.c: * (at your option) version 3 of the License.
These files are GPL v2, so they fit into Qemu:

* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation; either version 2 or
* (at your option) version 3 of the License.

They may be used with GPL v3, too.

By the way: is it "at your option", or should it be "at your opinion"?
Could one of the native speakers have a look, please?

Stefan

Re: [Qemu-devel] [PATCH, RFC] Update disassembler files from latest binutils

[Thiemo Seufer]

Stefan Weil wrote:
> Blue Swirl schrieb:
> > But there are a lot of files with GPL v3 now:
> >
> > bt-host.c: * (at your option) version 3 of the License.
> > bt-vhci.c: * (at your option) version 3 of the License.
> > hw/blizzard.c: * (at your option) version 3 of the License.
> > hw/blizzard_template.h: * (at your option) version 3 of the License.
> > hw/bt-hci-csr.c: * (at your option) version 3 of the License.
> > hw/bt-hid.c: * (at your option) version 3 of the License.
> > hw/bt.c: * (at your option) version 3 of the License.
> > hw/cbus.c: * (at your option) version 3 of the License.
> > hw/lm832x.c: * (at your option) version 3 of the License.
> > hw/nseries.c: * (at your option) version 3 of the License.
> > hw/omap.h: * (at your option) version 3 of the License.
> > hw/omap1.c: * (at your option) version 3 of the License.
> > hw/omap2.c: * (at your option) version 3 of the License.
> > hw/omap_dss.c: * (at your option) version 3 of the License.
> > hw/omap_mmc.c: * (at your option) version 3 of the License.
> > hw/onenand.c: * (at your option) version 3 of the License.
> > hw/palm.c: * (at your option) version 3 of the License.
> > hw/soc_dma.c: * (at your option) version 3 of the License.
> > hw/soc_dma.h: * (at your option) version 3 of the License.
> > hw/tmp105.c: * (at your option) version 3 of the License.
> > hw/tsc2005.c: * (at your option) version 3 of the License.
> > hw/tsc210x.c: * (at your option) version 3 of the License.
> > hw/tusb6010.c: * (at your option) version 3 of the License.
> > hw/twl92230.c: * (at your option) version 3 of the License.
> > hw/usb-bt.c: * (at your option) version 3 of the License.
> > hw/usb-musb.c: * (at your option) version 3 of the License.
> > hw/zaurus.c: * (at your option) version 3 of the License.
> These files are GPL v2, so they fit into Qemu:
> 
> * This program is free software; you can redistribute it and/or
> * modify it under the terms of the GNU General Public License as
> * published by the Free Software Foundation; either version 2 or
> * (at your option) version 3 of the License.
> 
> They may be used with GPL v3, too.
> 
> By the way: is it "at your option", or should it be "at your opinion"?
> Could one of the native speakers have a look, please?

"At your option", since the user can choose any of them.


Thiemo

Re: [Qemu-devel] [PATCH, RFC] Update disassembler files from latest binutils

[Thiemo Seufer]

Blue Swirl wrote:
> Hi,
> 
> The disassembler files should be updated to get newer instructions
> supported. This is currently not easy because the *-dis.c files are
> concatenated using several files from binutils. There are some Qemu
> specific changes.
> 
> The first patch introduces a new directory "dis", moves sparc-dis.c
> there, and splits it to three files as used in binutils: sparc-dis.c,
> sparc-opc.c and sparc.h.
> 
> The second patch updates the files from binutils 2.18. The real
> changes from 2002 binutils to current are not that large, but there is
> some code movement and I changed tabs to spaces at one point. The
> license changes from GPL v2 to v3.
> 
> I can introduce more staging patches if necessary. Comments?

Some files in Qemu are licensed as GPLv2 only. This is incompatible
with recent binutils files which are GPLv3 or later.


Thiemo

Re: [Qemu-devel] [PATCH, RFC] Update disassembler files from latest binutils

[Paul Brook]

> The second patch updates the files from binutils 2.18. The real
> changes from 2002 binutils to current are not that large, but there is
> some code movement and I changed tabs to spaces at one point. The
> license changes from GPL v2 to v3.

GPLv3 is not acceptable for qemu, which contains v2 only code.

Paul

Re: [Qemu-devel] [PATCH, RFC] Update disassembler files from latest binutils

[Blue Swirl]

On 10/25/08, Paul Brook <paul@codesourcery.com> wrote:
> > The second patch updates the files from binutils 2.18. The real
>  > changes from 2002 binutils to current are not that large, but there is
>  > some code movement and I changed tabs to spaces at one point. The
>  > license changes from GPL v2 to v3.
>
>
> GPLv3 is not acceptable for qemu, which contains v2 only code.

We could update once to binutils 2.17 which is GPL v2+. For Sparc this
would be about OK, since there is just one commit after GPLv3 switch.
But for i386 this would mean missing 30 to 50 commits.

Alternatively we could develop new disassemblers, for example based on
translate.c code (LGPL v2 for Sparc). Easy for Sparc, but a huge job
for i386/amd64.

Re: [Qemu-devel] [PATCH, RFC] Update disassembler files from latest binutils

[Laurent Desnogues]

On Sat, Oct 25, 2008 at 9:56 AM, Blue Swirl <blauwirbel@gmail.com> wrote:
>
> Alternatively we could develop new disassemblers, for example based on
> translate.c code (LGPL v2 for Sparc).

The main issue with that approach is that it may result in reproducing
translate bugs in the disassembler, and I am sure the target I am
familiar with has such bugs.

On the other hand if one uses translate to write a disassembler and
does an exhaustive disassembly and compares the result with
objdump output then both qemu and binutils (which also contains
holes for the ARM target, at least last time I checked) will benefit.


Laurent

Re: [Qemu-devel] [PATCH, RFC] Update disassembler files from latest binutils

[Laurent Desnogues]

On Sat, Oct 25, 2008 at 9:56 AM, Blue Swirl <blauwirbel@gmail.com> wrote:
>
>> GPLv3 is not acceptable for qemu, which contains v2 only code.
>
> We could update once to binutils 2.17 which is GPL v2+. For Sparc this
> would be about OK, since there is just one commit after GPLv3 switch.
> But for i386 this would mean missing 30 to 50 commits.

I took a quick look at binutils CVS repository: 2.17 released happened
in June '06.

According to ChangeLog, the switch to GPLv3 occured in July '07:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/opcodes/ChangeLog-2007?rev=1.2&content-type=text/x-cvsweb-markup&cvsroot=src

So I *guess* getting source out of CVS from June '07 should be safe
license wise, though probably slightly dangerous from a stability point
of view.  Perhaps Paul can comment on that?


Laurent

Re: [Qemu-devel] [PATCH, RFC] Update disassembler files from latest binutils

[Laurent Desnogues]

On Mon, Oct 27, 2008 at 10:54 AM, Laurent Desnogues
<laurent.desnogues@gmail.com> wrote:
> On Sat, Oct 25, 2008 at 9:56 AM, Blue Swirl <blauwirbel@gmail.com> wrote:
>>
>>> GPLv3 is not acceptable for qemu, which contains v2 only code.
>>
>> We could update once to binutils 2.17 which is GPL v2+. For Sparc this
>> would be about OK, since there is just one commit after GPLv3 switch.
>> But for i386 this would mean missing 30 to 50 commits.
>
> I took a quick look at binutils CVS repository: 2.17 released happened
> in June '06.
>
> According to ChangeLog, the switch to GPLv3 occured in July '07:
> http://sourceware.org/cgi-bin/cvsweb.cgi/src/opcodes/ChangeLog-2007?rev=1.2&content-type=text/x-cvsweb-markup&cvsroot=src
>
> So I *guess* getting source out of CVS from June '07 should be safe
> license wise, though probably slightly dangerous from a stability point
> of view.  Perhaps Paul can comment on that?

In case it matters, the ARM disassembler is exactly at the point I
mentionned: last commit before the switch to GPLv3.


Laurent