From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KvAFB-0000US-D4
	for qemu-devel@nongnu.org; Wed, 29 Oct 2008 08:33:49 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KvAF9-0000UG-Ri
	for qemu-devel@nongnu.org; Wed, 29 Oct 2008 08:33:48 -0400
Received: from [199.232.76.173] (port=54143 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KvAF9-0000UD-Mf
	for qemu-devel@nongnu.org; Wed, 29 Oct 2008 08:33:47 -0400
Received: from mx2.redhat.com ([66.187.237.31]:40928)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@redhat.com>) id 1KvAF9-0006q7-8E
	for qemu-devel@nongnu.org; Wed, 29 Oct 2008 08:33:47 -0400
Date: Wed, 29 Oct 2008 10:35:23 -0200
From: Glauber Costa <glommer@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU
Message-ID: <20081029123523.GG4269@poweredge.glommer>
References: <1225224814-9875-1-git-send-email-aliguori@us.ibm.com>
	<1225224814-9875-2-git-send-email-aliguori@us.ibm.com>
	<1225224814-9875-3-git-send-email-aliguori@us.ibm.com>
	<49078707.5000109@redhat.com> <49078955.2090109@codemonkey.ws>
	<5d6222a80810281604g39708040kf710725dce6413dd@mail.gmail.com>
	<4907A1FA.2060106@codemonkey.ws> <490832C3.4060602@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <490832C3.4060602@redhat.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Glauber Costa <glommer@gmail.com>, kvm-devel <kvm@vger.kernel.org>, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

On Wed, Oct 29, 2008 at 11:54:11AM +0200, Avi Kivity wrote:
> Anthony Liguori wrote:
>> Another place "hook" is updating a slot's dirty bitmap.  Right now,  
>> with my patchset we don't have live migration or the VGA RAM  
>> optimization.  There's nothing about the VGA RAM optimization that  
>> wouldn't work for QEMU.  I'm not sure that it really is an  
>> optimization in the context of TCG, but I certainly don't think it's  
>> any worse.  The only thing you really need is to query the KVM dirty  
>> bitmap when it comes time to enable start over querying the VGA dirty  
>> bits.
>
> I don't understand this.  The VGA optimization really is qemu's, the kvm  
> modifications only cater to the different way of getting the dirty bits.

As it seems to me, the real difference is that qemu has to explicitly set
certain regions as dirty, while kvm get dirty bit "automatically" from the kernel.

So I believe we can have markers on the code to refresh dirty bitmap for certain
area ranges (for kvm use), and also enable a manual override (for qemu). After that,
the cpu_physical_memory_get_dirty() will simply return whether or not the page is
dirty.

Also, kvm only tracks "dirty" bits, whereas qemu has at least three kinds of them.
But I think for now we can assume that kvm's dirty mean "all dirty"