qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@axis.com>
To: ths@networkno.de
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] MIPS: Avoid tcg internal error
Date: Wed, 29 Oct 2008 17:03:55 +0100	[thread overview]
Message-ID: <20081029160355.GG20499@edgar.se.axis.com> (raw)

Hello Thiemo,

I've got this in my tree, I needed it to avoid a tcg internal error
while booting mips linux. Feel free to apply it if it's correct.

Thanks

commit d30651cff0b75ab584ba8401e87b39738d134149
Author: Edgar E. Iglesias <edgar.iglesias@axis.com>
Date:   Wed Oct 29 13:54:48 2008 +0100

    MIPS: Initialize local temps before passing them to helpers.
    
    Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>

diff --git a/target-mips/translate.c b/target-mips/translate.c
index ec375e1..3c18235 100644
--- a/target-mips/translate.c
+++ b/target-mips/translate.c
@@ -5213,6 +5213,7 @@ static void gen_mftr(CPUState *env, DisasContext *ctx, int rt, int rd,
              (env->mvp->CP0_MVPConf0 & (0xff << CP0MVPC0_PTC)))
         tcg_gen_movi_tl(t0, -1);
     else if (u == 0) {
+        tcg_gen_movi_tl(t0, 0);
         switch (rt) {
         case 2:
             switch (sel) {
@@ -8163,6 +8164,7 @@ static void decode_opc (CPUState *env, DisasContext *ctx)
 #ifndef CONFIG_USER_ONLY
             if (!env->user_mode_only) {
                 TCGv t0 = tcg_temp_local_new(TCG_TYPE_TL);
+                tcg_gen_movi_tl(t0, 0);
 
                 op2 = MASK_MFMC0(ctx->opcode);
                 switch (op2) {

                 reply	other threads:[~2008-10-29 16:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081029160355.GG20499@edgar.se.axis.com \
    --to=edgar.iglesias@axis.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ths@networkno.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).