From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KvF1E-0008PV-QO
	for qemu-devel@nongnu.org; Wed, 29 Oct 2008 13:39:44 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KvF1D-0008PJ-Ak
	for qemu-devel@nongnu.org; Wed, 29 Oct 2008 13:39:43 -0400
Received: from [199.232.76.173] (port=56495 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KvF1D-0008PG-2d
	for qemu-devel@nongnu.org; Wed, 29 Oct 2008 13:39:43 -0400
Received: from mx2.redhat.com ([66.187.237.31]:56341)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@redhat.com>) id 1KvF1C-0008EZ-Lw
	for qemu-devel@nongnu.org; Wed, 29 Oct 2008 13:39:42 -0400
Date: Wed, 29 Oct 2008 15:41:22 -0200
From: Glauber Costa <glommer@redhat.com>
Message-ID: <20081029174122.GE11532@poweredge.glommer>
References: <1225224814-9875-1-git-send-email-aliguori@us.ibm.com>
	<1225224814-9875-2-git-send-email-aliguori@us.ibm.com>
	<1225224814-9875-3-git-send-email-aliguori@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1225224814-9875-3-git-send-email-aliguori@us.ibm.com>
Subject: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, kvm-devel <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>

resending, now with less quoted text:

> diff --git a/kvm-all.c b/kvm-all.c
> new file mode 100644
> index 0000000..4379071
> --- /dev/null
> +++ b/kvm-all.c
> @@ -0,0 +1,377 @@
> +/*
> + * QEMU KVM support
> + *
> + * Copyright IBM, Corp. 2008
> + *
> + * Authors:
> + *  Anthony Liguori   <aliguori@us.ibm.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + *
> + */
> +
> +#include <sys/types.h>
> +#include <sys/ioctl.h>
> +#include <sys/mman.h>
> +
> +#include <linux/kvm.h>
> +
> +#include "qemu-common.h"
> +#include "sysemu.h"
> +#include "kvm.h"
> +
> +//#define DEBUG_KVM
> +
> +#ifdef DEBUG_KVM
> +#define dprintf(fmt, ...) \
> +    do { fprintf(stderr, fmt, ## __VA_ARGS__); } while (0)
> +#else
> +#define dprintf(fmt, ...) \
> +    do { } while (0)
> +#endif
> +
> +typedef struct kvm_userspace_memory_region KVMSlot;

Actually, I don't think it is a good idea.
We may want to keep internal-only data tied to the slot, such the slot's
dirty bitmap if we do per-slot dirty tracking.

Of course there may be other ways to do it, but this is the cleaner
and more adequate since we're going through a fresh start.