From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH][RFC] Run time TCGv size check for debugging
Date: Wed, 29 Oct 2008 20:53:08 +0100 [thread overview]
Message-ID: <200810291953.09085.paul@codesourcery.com> (raw)
In-Reply-To: <f43fc5580810291231i32552e3dw71db583d5b2bad6f@mail.gmail.com>
On Wednesday 29 October 2008, Blue Swirl wrote:
> Hi,
>
> When emulating a mixed 32/64 bit Qemu target CPUs it's easy to confuse
> the TCGv size, passing 32 bit TCGv to a function expecting a 64 bit
> one and vice versa. This patch adds a run time sanity check for TCGv
> sizes.
Would it make more sense to push these down into tcg_gen_op* ?
tcg-op.h is already fairly unwieldy.
I wonder if it's worth adding TCG_LOW to enable checking on 32-bit hosts.
For futureproofing I'd name things FOO_I32 rather than FOO_32.
Paul
next prev parent reply other threads:[~2008-10-29 19:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 19:31 [Qemu-devel] [PATCH][RFC] Run time TCGv size check for debugging Blue Swirl
2008-10-29 19:53 ` Paul Brook [this message]
2008-10-29 20:06 ` Blue Swirl
2008-10-29 20:14 ` Paul Brook
2008-10-29 20:25 ` Blue Swirl
2008-10-29 21:37 ` [Qemu-devel] " Fabrice Bellard
2008-10-30 0:07 ` Paul Brook
2008-10-30 9:38 ` Fabrice Bellard
2008-11-01 12:00 ` Blue Swirl
2008-11-01 12:59 ` Paul Brook
2008-11-01 16:56 ` Paul Brook
2008-11-01 17:03 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810291953.09085.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).